mailmap: avoid out-of-bounds memory access
authorRomain Francoise <romain@orebokech.com>
Sat, 27 Oct 2012 22:49:55 +0000 (00:49 +0200)
committerJeff King <peff@peff.net>
Sun, 28 Oct 2012 11:50:18 +0000 (07:50 -0400)
commit3174bc5ccfea34717a8dac2175c1951239a4985d
tree401f10be8b7f4bf84dc9ed7c46774fb4f0fbd650
parent7e2010537e96d0a1144520222f20ba1dc3d61441
mailmap: avoid out-of-bounds memory access

AddressSanitizer (http://clang.llvm.org/docs/AddressSanitizer.html)
complains of a one-byte buffer underflow in parse_name_and_email() while
running the test suite. And indeed, if one of the lines in the mailmap
begins with '<', we dereference the address just before the beginning of
the buffer when looking for whitespace to remove, before checking that
we aren't going too far.

So reverse the order of the tests to make sure that we don't read
outside the buffer.

Signed-off-by: Romain Francoise <romain@orebokech.com>
Signed-off-by: Jeff King <peff@peff.net>
mailmap.c