Annotate internal_error with the attribute noreturn
authorJustus Winter <4winter@informatik.uni-hamburg.de>
Mon, 24 Sep 2012 15:21:19 +0000 (17:21 +0200)
committerDavid Bremner <bremner@debian.org>
Thu, 27 Sep 2012 15:52:06 +0000 (12:52 -0300)
commit2f40ca28a4d63df941525801735d05b5b2b86f91
tree73ade8c258fb20d1bc845e0f8c605054d826a5ac
parentfaf6ede3ef7b09df0d61264cb7a907860d69abbb
Annotate internal_error with the attribute noreturn

Annotating functions that do not return with the noreturn attribute
(which is understood by both gcc and clang) prevents static analyzers
from generating false positives (internal_error is used to terminate
the process and is used extensively in error handling code paths).

Remove the return statement that was placed there to appease the
compiler. Functions annotated with noreturn are not supposed to return
any values.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
util/error_util.c
util/error_util.h