start_command: do not clobber cmd->env on Windows code path
authorJohannes Sixt <j6t@kdbg.org>
Fri, 11 Sep 2009 17:40:08 +0000 (19:40 +0200)
committerJunio C Hamano <gitster@pobox.com>
Fri, 11 Sep 2009 23:33:54 +0000 (16:33 -0700)
commit2affea4125a0ae6c528a14f14731748c1fad9a8a
tree81ba1ff206e66c92aa340ba4615a3d901039b150
parent434a6db7dcf8688fe08098e218113c18b7c9aeaf
start_command: do not clobber cmd->env on Windows code path

Previously, it would not be possible to call start_command twice for the
same struct child_process that has env set.

The fix is achieved by moving the loop that modifies the environment block
into a helper function. This also allows us to make two other helper
functions static.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
compat/mingw.c
compat/mingw.h
run-command.c