net-proxy/haproxy: Fix init script
authorPatrick Lauer <patrick@gentoo.org>
Thu, 30 Nov 2017 07:20:59 +0000 (07:20 +0000)
committerPatrick Lauer <patrick@gentoo.org>
Thu, 30 Nov 2017 07:20:59 +0000 (07:20 +0000)
commit1016c8d09a77369c4b37e511bf6b3f03922f7c23
treeb4d41e9a7e49980514e163b16ac1843df36dd478
parent4d4bb4bf5cd0afc648a920066adf7d4d5d6bf50f
net-proxy/haproxy: Fix init script

The change in https://bugs.gentoo.org/show_bug.cgi?id=584410 only worked because of
multiple bugs interacting.

Due to variable shadowing https://bugs.gentoo.org/show_bug.cgi?id=639164 the loop did not
actually work, and the /run/haproxy.pid was used in every loop iteration.

This only worked because of a bug in openrc: https://bugs.gentoo.org/show_bug.cgi?id=639218
which was fixed in 0.34.11

So before it killed all processes called haproxy if nbproc > 1 in the config
(which means multiple haproxy instances are all killed if one is stopped!)
After the bugfix it doesn't kill, so we're back to the original situation of leftover
processes. And we don't want to rely on the cgroup killer!

The fix is obviously to use start-stop-daemon directly instead of calling openrc
internals that don't do what you think they do.

Package-Manager: Portage-2.3.16, Repoman-2.3.6
RepoMan-Options: --force
net-proxy/haproxy/Manifest
net-proxy/haproxy/files/haproxy.initd-r4 [deleted file]
net-proxy/haproxy/files/haproxy.initd-r6 [moved from net-proxy/haproxy/files/haproxy.initd-r5 with 97% similarity]
net-proxy/haproxy/haproxy-1.5.19-r2.ebuild [moved from net-proxy/haproxy/haproxy-1.5.19-r1.ebuild with 98% similarity]
net-proxy/haproxy/haproxy-1.6.11-r2.ebuild [moved from net-proxy/haproxy/haproxy-1.6.11-r1.ebuild with 99% similarity]
net-proxy/haproxy/haproxy-1.6.13-r3.ebuild [moved from net-proxy/haproxy/haproxy-1.6.13-r2.ebuild with 99% similarity]
net-proxy/haproxy/haproxy-1.6.9999-r2.ebuild [moved from net-proxy/haproxy/haproxy-1.7.9.ebuild with 99% similarity]
net-proxy/haproxy/haproxy-1.7.8.ebuild [deleted file]
net-proxy/haproxy/haproxy-1.7.9-r1.ebuild [moved from net-proxy/haproxy/haproxy-1.6.9999-r1.ebuild with 99% similarity]
net-proxy/haproxy/haproxy-1.7.9999-r1.ebuild [deleted file]
net-proxy/haproxy/haproxy-1.7.9999-r2.ebuild [moved from net-proxy/haproxy/haproxy-1.7.7.ebuild with 99% similarity]