git-p4: remove bash-ism in t9800
authorPete Wyckoff <pw@padd.com>
Sun, 26 Feb 2012 15:37:27 +0000 (10:37 -0500)
committerJunio C Hamano <gitster@pobox.com>
Mon, 27 Feb 2012 00:20:18 +0000 (16:20 -0800)
commit09ccbd34f4fe37a682a10b23d86f915b2a8a9c28
treed5938add397aa3121ce70918424e3308cbeccd55
parent8d93a5ac68d12a01681a0c2a8d2f799da5cb9fa9
git-p4: remove bash-ism in t9800

This works in both bash and dash:

    $ bash -c 'VAR=1 env' | grep VAR
    VAR=1
    $ dash -c 'VAR=1 env' | grep VAR
    VAR=1

But environment variables assigned this way are not necessarily propagated
through a function in POSIX compliant shells:

    $ bash -c 'f() { "$@"
    }; VAR=1 f "env"' | grep VAR
    VAR=1
    $ dash -c 'f() { "$@"
    }; VAR=1 f "env"' | grep VAR

Fix constructs like this, in particular, setting variables through
test_must_fail.

Based-on-patch-by: Vitor Antunes <vitor.hda@gmail.com>
Signed-off-by: Pete Wyckoff <pw@padd.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t9800-git-p4-basic.sh