X-Git-Url: http://git.tremily.us/?a=blobdiff_plain;f=c9%2Fbf02137b83ffa3b537dd8002a3c70663cf81ed;fp=c9%2Fbf02137b83ffa3b537dd8002a3c70663cf81ed;h=969a876f1fde4e92cf484cc9db3bfbfe8371228c;hb=80b09803ea2866b39ef13eef04fdc45d4d4fb30a;hp=0000000000000000000000000000000000000000;hpb=d420bce9162cac8dccfde7c039c9c461a3e9f764;p=notmuch-archives.git diff --git a/c9/bf02137b83ffa3b537dd8002a3c70663cf81ed b/c9/bf02137b83ffa3b537dd8002a3c70663cf81ed new file mode 100644 index 000000000..969a876f1 --- /dev/null +++ b/c9/bf02137b83ffa3b537dd8002a3c70663cf81ed @@ -0,0 +1,84 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 1BAC86DE17ED + for ; Tue, 8 Dec 2015 05:15:06 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.706 +X-Spam-Level: +X-Spam-Status: No, score=0.706 tagged_above=-999 required=5 tests=[AWL=0.054, + SPF_NEUTRAL=0.652] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id e0RlS3NTyqh5 for ; + Tue, 8 Dec 2015 05:15:03 -0800 (PST) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by arlo.cworth.org (Postfix) with ESMTP id 70A5F6DE17CB + for ; Tue, 8 Dec 2015 05:15:03 -0800 (PST) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 1FEEB10004A; + Tue, 8 Dec 2015 15:15:09 +0200 (EET) +From: Tomi Ollila +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH] lib: have two definitions of NOTMUCH_DEPRECATED macro +In-Reply-To: <87egexyusl.fsf@zancas.localnet> +References: <1439303834-27030-1-git-send-email-tomi.ollila@iki.fi> + <87egexyusl.fsf@zancas.localnet> +User-Agent: Notmuch/0.21+32~g73439f8 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 08 Dec 2015 13:15:06 -0000 + +On Tue, Dec 08 2015, David Bremner wrote: + +> Tomi Ollila writes: +> +>> Some compilers (older than gcc 4.5 and clang 2.9) do support +>> __attribute__ ((deprecated)) but not +>> __attribute__ ((deprecated("message"))). +>> +>> Check (clang) and know (gcc) which versions support which variants +>> and make two definitions of define NOTMUCH_DEPRECATED macro; +>> one with and and one without the ("message") part. +>> +>> __has_extension() replacement was modeled after __has_attribute() +>> definition in compat/function-attributes.h. Thanks Justus. +> +> Hi Tomi; +> +> I keep coming back to review this patch, but I'm blocked by the fact +> that clang++ is broken on Debian (and lots of other places, I guess) for +> months. +> +> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=797038 + +Personally I am not fond of the commit message but I don't want to +emphasize the change by sending an updated one. We could move it +to *moreinfo* to get it out of our ways for the time being -- and +see whether things stabilize (to one way or another) to decide +whether to push this further. + +> +> d + +Tomi