Return-Path: <bremner@unb.ca>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id CD182429E20
	for <notmuch@notmuchmail.org>; Mon,  9 May 2011 05:20:47 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -2.3
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
	tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id bieIc6TURAfn for <notmuch@notmuchmail.org>;
	Mon,  9 May 2011 05:20:47 -0700 (PDT)
Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 30653431FB5
	for <notmuch@notmuchmail.org>; Mon,  9 May 2011 05:20:47 -0700 (PDT)
Received: from zancas.localnet
	(fctnnbsc30w-142167162115.pppoe-dynamic.High-Speed.nb.bellaliant.net
	[142.167.162.115]) (authenticated bits=0)
	by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id p49CKgKI002998
	(version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO);
	Mon, 9 May 2011 09:20:42 -0300
Received: from bremner by zancas.localnet with local (Exim 4.72)
	(envelope-from <bremner@unb.ca>)
	id 1QJPS5-0002k3-Mj; Mon, 09 May 2011 09:20:41 -0300
From: David Bremner <david@tethera.net>
To: Anton Khirnov <anton@khirnov.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] python/thread: always return a string in
	get_subject/authors
In-Reply-To: <1304924794-20380-1-git-send-email-anton@khirnov.net>
References: <1304924794-20380-1-git-send-email-anton@khirnov.net>
User-Agent: Notmuch/0.5-167-g6c53770 (http://notmuchmail.org) Emacs/23.2.1
	(x86_64-pc-linux-gnu)
Date: Mon, 09 May 2011 09:20:41 -0300
Message-ID: <87bozcvzdy.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Mon, 09 May 2011 12:20:47 -0000

On Mon,  9 May 2011 09:06:34 +0200, Anton Khirnov <anton@khirnov.net> wrote:
> Now None is returned when those don't exist, which is inconvenient to
> deal with.

I'm not using the python bindings, but from a philosophical point of
view, this change makes me a bit uncomfortable since it apparently
merges two cases together, and makes an error (no Subject)
indistinguishable from an odd situation (Subject of empty string).
Or am I missing something here?

All the best,

David