To: Jameson Graef Rollins <jrollins@finestructure.net>,
	Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message
	to pop out to parent buffer if at end
In-Reply-To: <87aa5lqtww.fsf@servo.finestructure.net>
References: <871uqy19yo.fsf@servo.finestructure.net>
	<1326823531-14549-1-git-send-email-jrollins@finestructure.net>
	<1326823531-14549-2-git-send-email-jrollins@finestructure.net>
	<1326823531-14549-3-git-send-email-jrollins@finestructure.net>
	<1326823531-14549-4-git-send-email-jrollins@finestructure.net>
	<cunfwfdo2dw.fsf@hotblack-desiato.hh.sledj.net>
	<87aa5lqtww.fsf@servo.finestructure.net>
User-Agent: Notmuch/0.11+64~g42e8f66 (http://notmuchmail.org) Emacs/24.0.92.1
	(x86_64-pc-linux-gnu)
From: David Edmondson <dme@dme.org>
Date: Wed, 18 Jan 2012 08:56:26 +0000
Message-ID: <cunpqehmls5.fsf@hotblack-desiato.hh.sledj.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Wed, 18 Jan 2012 00:47:11 -0800, Jameson Graef Rollins <jrollins@finestr=
ucture.net> wrote:
> > >      (while (and (setq r (notmuch-show-goto-message-next))
> > >  		(not (notmuch-show-message-visible-p))))
> > >      (if r
> > >  	(progn
> > >  	  (notmuch-show-mark-read)
> > >  	  (notmuch-show-message-adjust))
> > > -      (goto-char (point-max)))))
> > > +      (if (and parent-buffer pop-at-end)
> > > +	  (progn
> > > +	    (kill-this-buffer)
> > > +	    (switch-to-buffer parent-buffer)
> > > +	    (forward-line 1))
> > > +	(goto-char (point-max))))))
> >=20
> > Can you explain in words how this is expected to behave please?
>=20
> Do you see a problem?

Not a problem, just trying to understand the behaviour (I have to revive
my advance/rewind patches at some point).

> If there is not another message, but there is a parent buffer and the
> pop-at-end variable is set, kill this buffer, go the parent, and move to
> the next thread.  Otherwise, go to the max point in the buffer.

I'm used to the cursor going to the bottom of the thread to let me know
that I reached the end, then I hit 'space' and move on to the next
thread. Will that behaviour be retained with this patch? (Well,
including your other patch which seemed to set `pop-at-end'.)

It's one of those things that I have to try out to understand properly I
expect.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk8WiToACgkQaezQq/BJZRYYBgCfaiztFuuQHWLGVECXcTTySd5U
JwoAnA84p0NTA9aZlwF8i1POrNZ5XcYw
=SPO1
-----END PGP SIGNATURE-----
--=-=-=--