From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org, Peter Wang <novalazy@gmail.com>
Subject: Re: [PATCH v4 0/3] indicate length of omitted body content
In-Reply-To: <1355057796-19260-1-git-send-email-markwalters1009@gmail.com>
References: <1355057796-19260-1-git-send-email-markwalters1009@gmail.com>
User-Agent: Notmuch/0.14+155~g7edfdc3 (http://notmuchmail.org) Emacs/23.4.1
	(x86_64-pc-linux-gnu)
Date: Sun, 09 Dec 2012 19:21:18 +0000
Message-ID: <87vccb2frl.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list


On Sun, 09 Dec 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> This is a (trivially) rebased version of
> id:1344428872-12374-1-git-send-email-novalazy@gmail.com (There was one
> bit of context clash, and a small change to one of the sexp tests to
> mirror the same change for the json test)
>
>
> The patch is Peter's not mine so as a reviewer +1 from me.
>

Hi (sorry Peter I had assumed git send-email would have cc'd you on my
rebase earlier today)

There was some discussion about this patch series on irc and the general
view was favourable but that, for consistency, all omitted parts should
received a content-length (including text/html). This is a little messy
to code into the if else stuff: Jani suggested putting
content-length/content-encoding into a small function.

Anyway I had hope it was just a trivial rebase and could go in, but the
above will take a bit longer to do neatly so I will leave it for now.

I think it could go in relatively easily if resubmitted with this
change but I will mark this version `moreinfo'.


Best wishes

Mark

> Best wishes
>
> Mark
>
>
> Peter Wang (3):
>   test: normalize only message filenames in show json
>   show: indicate length, encoding of omitted body content
>   test: conform to content length, encoding fields
>
>  devel/schemata   |    9 ++++++++-
>  notmuch-show.c   |   14 ++++++++++++++
>  test/crypto      |   30 +++++++++++++++++++++---------
>  test/json        |    4 +++-
>  test/multipart   |   11 ++++++-----
>  test/sexp        |    2 +-
>  test/test-lib.sh |    2 +-
>  7 files changed, 54 insertions(+), 18 deletions(-)
>
> -- 
> 1.7.9.1