Date: Tue, 4 Oct 2011 08:00:46 +0300
From: Ali Polatel <polatel@gmail.com>
To: David Bremner <david@tethera.net>
Subject: Re: [PATCH] lib: make find_message{,by_filename) report errors
Message-ID: <20111004050046.GA6048@hayalet>
Mail-Followup-To: David Bremner <david@tethera.net>,
	Austin Clements <amdragon@MIT.EDU>,
	Notmuch Mailing List <notmuch@notmuchmail.org>
References: <20110930064712.GA30012@hayalet>
	<cover.1317456435.git.alip@exherbo.org>
	<8739f9muhp.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="opJtzjQTFsWo+cga"
Content-Disposition: inline
In-Reply-To: <8739f9muhp.fsf@zancas.localnet>
Organization: Pink Floyd
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: Notmuch Mailing List <notmuch@notmuchmail.org>,
	Austin Clements <amdragon@MIT.EDU>
Precedence: list


--opJtzjQTFsWo+cga
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

David Bremner yazm=C4=B1=C5=9F:
>On Sat,  1 Oct 2011 11:12:23 +0300, Ali Polatel <polatel@gmail.com> wrote:
>> From: Ali Polatel <alip@exherbo.org>
>>
>> Looks like the patch did not make it correctly the first time.
>> Resending using git-send-email=E2=84=A2
>>
>> You may also find the commit in my notmuch repository:
>> git://github.com/alip/notmuch.git branch: find_message
>
>
>Hi Ali;
>
>Thanks for reworking this patch. I looked at branch find_message-v2
>in your repo. I have a few comments.

Thanks for going over the patch, expect a new set of patches soon!

>- In the comments for _resolve_message_id_to_thread_id I guess thread_id
>  should be thread_id_ret?

Fixed.

>- in notmuch_database_find_message_by_file_name, I'm not sure why you
>  set status to NOTMUCH_STATUS_OUT_OF_MEMORY in the catch block. Is this
>  a typo?

Looks like a copy & paste error. I must have blindly copied the error
=66rom the previous block. Fixed.

>- after the DONE: label of the same routine, how is *message_ret destroyed?
>  does it need to wait until the talloc context "notmuch" is freed?

Yes, I have modified it to call notmuch_message_destroy() in case
'*message_ret' is non-NULL after the DONE:

>- I don't really get the change of user to caller around notmuch.h:286
>  It is not a big deal, but I guess we should try to be consistent.

I don't get what you mean by consistency here but this hunk is unrelated
to the problem which the patch is trying to address.
Reverted.

>David
>
>

         -alip

--opJtzjQTFsWo+cga
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (GNU/Linux)

iEYEARECAAYFAk6Kkv4ACgkQQU4yORhF8iBInwCgpop38ePUu3GYNOvodxl1vXZ6
u7EAn0lJf4uTgDGLVa0oi0R/003RSm21
=Zjxr
-----END PGP SIGNATURE-----

--opJtzjQTFsWo+cga--