Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 8111E429E54 for ; Mon, 23 Jan 2012 11:05:09 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 1.463 X-Spam-Level: * X-Spam-Status: No, score=1.463 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, RDNS_DYNAMIC=0.363, TO_NO_BRKTS_DYNIP=1] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j0gusbKpNFLY for ; Mon, 23 Jan 2012 11:05:08 -0800 (PST) Received: from xhlj.maillard.im (cha51-3-88-164-105-66.fbx.proxad.net [88.164.105.66]) by olra.theworths.org (Postfix) with ESMTP id 5C1E2429E21 for ; Mon, 23 Jan 2012 11:05:08 -0800 (PST) Received: from xhlj.maillard.im (xhlj.maillard.im [127.0.0.1]) by xhlj.maillard.im (Postfix) with ESMTP id 076BA20640; Mon, 23 Jan 2012 20:05:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=maillard.im; h=from:to :subject:in-reply-to:references:reply-to:date:message-id :mime-version:content-type; s=postfix; bh=Yo2WkGB8QBeupgq5Pv7Bvk ruMXA=; b=XNXVr2D0TndMf/YzeV1k9K1WckFmt5EOitu7bhN5J5IKMtdr/KRYkP EnurPF1AFvQB3pIDQniUtIJ+gy20ruLnDG8d+1KVppRIQYThdowfaHjUXjLlz1G8 B9WfjR04CiazFVIiLwReVUxJK8zjEXxAvUisvPp+WBV3OZLKqPFWo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=maillard.im; h=from:to :subject:in-reply-to:references:reply-to:date:message-id :mime-version:content-type; q=dns; s=postfix; b=dSsgmm4HxxQwbUgZ FP9hmlWE/5Cc2odIbdYsPHynY6rHMbQGXiY78b8biHbkt/kwE/2g/pDjzKbUyFHd rI2APhlOMfBpajziMoqmry3bEyJL0IlAFkcA4yAEpiGjUSUesBpoFmggCFgOIM6k zptKo/w7/SHXsZ9VMgXlMCCvPyg= Received: from maillard.im (cha51-3-88-164-105-66.fbx.proxad.net [88.164.105.66]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by xhlj.maillard.im (Postfix) with ESMTPSA; Mon, 23 Jan 2012 20:05:05 +0100 (CET) From: Xavier Maillard To: Dmitry Kurochkin , notmuch@notmuchmail.org Subject: Re: [PATCH 08/10] test: set variables using `let' instead of `setq' in Emacs tests In-Reply-To: <1309236311-2162-8-git-send-email-dmitry.kurochkin@gmail.com> References: <1309236311-2162-1-git-send-email-dmitry.kurochkin@gmail.com> <1309236311-2162-8-git-send-email-dmitry.kurochkin@gmail.com> User-Agent: Notmuch/0.11 (http://notmuchmail.org) Emacs/23.2.1 (i486-slackware-linux-gnu) Date: Mon, 23 Jan 2012 20:05:06 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Xavier Maillard List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jan 2012 19:05:09 -0000 On Tue, 28 Jun 2011 08:45:09 +0400, Dmitry Kurochkin wrote: > Using `setq' for setting variables in Emacs tests affect other > tests that may run in the same Emacs environment. Currently it > works because each test is run in a separate Emacs instance. But > in the future multiple tests will run in a single Emacs instance. > The patch changes all variables to use `let', so the scope of the > change is limited to a single test. +1 (definetely) /Xavier