Date: Sat, 4 Jan 2014 23:37:42 +0100
From: Thomas Klausner <tk@giga.or.at>
To: David Bremner <david@tethera.net>
Subject: Re: notmuch-0.16: realpath() compatibility issue; clang visibility
	problem
Message-ID: <20140104223742.GC16514@danbala.tuwien.ac.at>
References: <20140103214735.GG27614@danbala.tuwien.ac.at>
	<sfid-H20140104-145824-+018.98-1@spamfilter.osbf.lua>
	<871u0nnaw8.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <871u0nnaw8.fsf@zancas.localnet>
Cc: notmuch@notmuchmail.org
Precedence: list

On Sat, Jan 04, 2014 at 09:18:15AM -0400, David Bremner wrote:
> Thomas Klausner <tk@giga.or.at> writes:
> 
> >                                 ^
> > ./lib/notmuch-private.h:52:13: note: previous attribute is here
> > #pragma GCC visibility push(hidden)
> >             ^
> 
> The clang related issues might be fixed in 0.17; can you try that (or
> git master)?

Yes, 0.17 fixed that problem.

> >      size_t length;
> > -    char *data, *filename;
> > +    char *data, filename[MAXPATHLEN];
> >      GError *error = NULL;
> 
> I'm not sure what the right answer is here. MATHPATHLEN (and PATH_MAX)
> are not necessarily defined; in particular this would break
> compilation on GNU Hurd. Perhaps we should ship a compatibility
> implementation of a POSIX.1-2008 compatible [1] realpath. Or maybe
> realpath can be avoided completely here.

A compatibility implementation for POSIX.1-2008-realpath would be
great, as would be avoiding the call. Why is it necessary to resolve
$HOME here?

> > +	    strcpy(filename, config->filename);
> 
> Any reason not to use strncpy here?

You're right, that'd be better here.

> Of course bug reports and fixes in any form are always welcome, but even
> more appreciated if they roughly follow [2]; mainly patches from git
> with sensible commit messages, and some minor coding style issues.

Thanks for the comments,
 Thomas