Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 1E07E431FBC for ; Mon, 15 Feb 2010 02:03:54 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.028 X-Spam-Level: X-Spam-Status: No, score=-2.028 tagged_above=-999 required=5 tests=[AWL=0.571, BAYES_00=-2.599] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8KEGJnEtqq9Z for ; Mon, 15 Feb 2010 02:03:52 -0800 (PST) Received: from mail-fx0-f224.google.com (mail-fx0-f224.google.com [209.85.220.224]) by olra.theworths.org (Postfix) with ESMTP id 48D16431FAE for ; Mon, 15 Feb 2010 02:03:52 -0800 (PST) Received: by fxm24 with SMTP id 24so5639353fxm.0 for ; Mon, 15 Feb 2010 02:03:51 -0800 (PST) Received: by 10.87.62.1 with SMTP id p1mr8530507fgk.42.1266228231242; Mon, 15 Feb 2010 02:03:51 -0800 (PST) Received: from aw.hh.sledj.net (host83-217-165-81.dsl.vispa.com [83.217.165.81]) by mx.google.com with ESMTPS id 16sm2924241fxm.0.2010.02.15.02.03.50 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 15 Feb 2010 02:03:50 -0800 (PST) Received: by aw.hh.sledj.net (Postfix, from userid 1000) id 9A9D33A018; Mon, 15 Feb 2010 10:03:32 +0000 (GMT) To: notmuch@notmuchmail.org In-Reply-To: <1266226909-19360-1-git-send-email-dme@dme.org> References: <1266226909-19360-1-git-send-email-dme@dme.org> From: David Edmondson Date: Mon, 15 Feb 2010 10:03:32 +0000 Message-ID: <873a12hl3f.fsf@aw.hh.sledj.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [notmuch] [PATCH] notmuch.el: Colour cited regions and signatures with message-cited-text-face. X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2010 10:03:54 -0000 This version is over-eager in marking (non-)signatures. The second call to 'overlay-put' needs to move inside the 'if' a line below. On Mon, 15 Feb 2010 09:41:49 +0000, David Edmondson wrote: > --- > notmuch.el | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/notmuch.el b/notmuch.el > index 8090b2f..3e8e50d 100644 > --- a/notmuch.el > +++ b/notmuch.el > @@ -703,6 +703,7 @@ is what to put on the button." > (let* ((cite-start (match-beginning 0)) > (cite-end (match-end 0)) > (cite-lines (count-lines cite-start cite-end))) > + (overlay-put (make-overlay cite-start cite-end) 'face 'message-cited-text-face) > (when (> cite-lines (1+ notmuch-show-citation-lines-prefix)) > (goto-char cite-start) > (forward-line notmuch-show-citation-lines-prefix) > @@ -718,6 +719,7 @@ is what to put on the button." > (let* ((sig-start (match-beginning 0)) > (sig-end (match-end 0)) > (sig-lines (1- (count-lines sig-start end)))) > + (overlay-put (make-overlay sig-start end) 'face 'message-cited-text-face) > (if (<= sig-lines notmuch-show-signature-lines-max) > (notmuch-show-region-to-button > sig-start > -- > 1.6.6.1 > dme. -- David Edmondson, http://dme.org