DomainKey-Signature: a=rsa-sha1; c=nofws; d=SSpaeth.de; h=from:to:subject
	:in-reply-to:references:date:message-id:mime-version:
	content-type; q=dns; s=sspaeth.de; b=Eys+fajkdkZFT7MtAndILYPPgvI
	8XTYsGJHYLIFB5fSjq6LzgZcph4lSrjPQDejEm0cMl0BnMy0aXncrW5UXN8Adv7r
	oTtIXFoHbtjr4/VtQaYmXEavanGkxJYEgcVWfa3VDsofrhKqBiq5zhz5G86SBdsF
	J1ZThIoiOmtJT/mA=
From: Sebastian Spaeth <Sebastian@SSpaeth.de>
To: Patrick Totzke <patricktotzke@googlemail.com>,
	Justus Winter <4winter@informatik.uni-hamburg.de>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] python: annotate all calls into libnotmuch with types
In-Reply-To: <4eddf2b1.4288980a.0b74.5557@mx.google.com>
References:
 <1318198374-926-1-git-send-email-4winter@informatik.uni-hamburg.de>
	<1318198374-926-2-git-send-email-4winter@informatik.uni-hamburg.de>
	<4eddf2b1.4288980a.0b74.5557@mx.google.com>
User-Agent: Notmuch/0.10+58~g935365d (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Tue, 06 Dec 2011 13:05:53 +0100
Message-ID: <87fwgx7vmm.fsf@SSpaeth.de>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Tue, 06 Dec 2011 10:46:31 +0000, Patrick Totzke <patricktotzke@googlemai=
l.com> wrote:
> This commit breaks raising XapianErrors for me.
>=20
> If I lock the index with some `notmuch tag +test '*'`
> and try to write to it in alot, i get a segfault and
> the following on stderr:
>=20
> Xapian exception occurred opening database: Unable to get write lock on
> /home/pazz/mail/.notmuch/xapian: already locked

Hi Justus,
I can confirm that this patch breaks as Totzke has described it:

http://git.notmuchmail.org/git/notmuch/commitdiff/3434d194026ff65217d9342ff=
e511f67fd71e79f

This change makes python segfault with a Xapianerror on stdout rather
than the python exception that we were seeing before this patch.

=2D     _open.restype =3D c_void_p
+     _open.restype =3D NotmuchDatabaseP


As the patch obviously fixed other crashers I would like to not revert
it. Can you have a look and see if you find a cause of that?

Sebastian

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk7eBSIACgkQVYX1jMgnoGLsHQCgjHxfzvtQ6NQclpUJyO6pBkOx
XC0An12Bn4vVfYBxSjS+qIlFbHOdV8NS
=epRq
-----END PGP SIGNATURE-----
--=-=-=--