Return-Path: <david@tethera.net>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 91B21431FAF
	for <notmuch@notmuchmail.org>; Sun,  8 Sep 2013 18:52:20 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id GsRXALngl7cW for <notmuch@notmuchmail.org>;
	Sun,  8 Sep 2013 18:52:16 -0700 (PDT)
Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id A05A4431FAE
	for <notmuch@notmuchmail.org>; Sun,  8 Sep 2013 18:52:16 -0700 (PDT)
Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
	(envelope-from <david@tethera.net>)
	id 1VIqeA-0000WH-SK; Sun, 08 Sep 2013 22:52:10 -0300
Received: (nullmailer pid 6334 invoked by uid 1000); Mon, 09 Sep 2013
	01:52:07 -0000
From: David Bremner <david@tethera.net>
To: "Kevin J. McCarthy" <kevin@8t8.us>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 1/1] notmuch-mutt: Fix tagging issues
In-Reply-To: <20130907170757.GA407@zaogao.lan>
References: <20130906221520.GC4226@zaogao.lan>
	<m2mwnprq7o.fsf@guru.guru-group.fi> <20130907155748.GD4226@zaogao.lan>
	<20130907170757.GA407@zaogao.lan>
User-Agent: Notmuch/0.16+37~g9701e9c (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Sun, 08 Sep 2013 22:52:07 -0300
Message-ID: <87sixe3goo.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain
Cc: Tomi Ollila <tomi.ollila@iki.fi>, Stefano Zacchiroli <zack@upsilon.cc>
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Sep 2013 01:52:20 -0000

"Kevin J. McCarthy" <kevin@8t8.us> writes:

> This patch fixes three issues with "notmuch-mutt tag":
>
> 1. The message_id was not shell quoted.
>    Thanks to Jason Miller for the bug report and patch.
>
> 2. The tags passed into tag_action() were not being properly quoted.
>    The "join before shell_quote" was combining multiple tags into a
>    single argument to notmuch tag: '+one -two -three' instead of
>    '+one' '-two' '-three'.
>
> 3. A "--" was added between the tags and search-term as shown in the
>    current notmuch-tag man page.

pushed.

d