Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 8B8F1431FAF for ; Thu, 15 Nov 2012 07:55:15 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KO2Z0SEp6QyW for ; Thu, 15 Nov 2012 07:55:15 -0800 (PST) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by olra.theworths.org (Postfix) with ESMTP id 1DB1E431FAE for ; Thu, 15 Nov 2012 07:55:15 -0800 (PST) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id 7E4AA1000E2; Thu, 15 Nov 2012 17:55:14 +0200 (EET) From: Tomi Ollila To: Blake Jones , notmuch@notmuchmail.org Subject: Re: [PATCH v3 00/10] Solaris support In-Reply-To: <1352859005-18631-1-git-send-email-blakej@foo.net> References: <1352859005-18631-1-git-send-email-blakej@foo.net> User-Agent: Notmuch/0.14+84~g8a199bf (http://notmuchmail.org) Emacs/24.2.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Nov 2012 15:55:15 -0000 On Wed, Nov 14 2012, Blake Jones wrote: > Updated based on comments from Tomi Ollila last week: > > - Cleaned up the $(INSTALL) changes in vim/Makefile. > - Fixed gen-version-script to be compliant with old "sh" implementation. Ok -- tests on linux reveal... Checking for strsep... No (will use our own instead). and Checking for standard version of asctime_r... No (will define _POSIX_PTHREAD_SEMANTICS to get it). testing... $ gcc compat/have_strsep.c compat/have_strsep.c: In function =E2=80=98main=E2=80=99: compat/have_strsep.c:7:21: error: expected identifier or =E2=80=98(=E2=80= =99 before =E2=80=98const=E2=80=99 compat/have_strsep.c:9:29: error: =E2=80=98delim=E2=80=99 undeclared (first= use in this function) compat/have_strsep.c:9:29: note: each undeclared identifier is reported only once for each function it appears in zsh: exit 1 gcc compat/have_strsep.c --- It is very easy to spot the problem ;) $ gcc compat/check_asctime.c compat/check_asctime.c: In function =E2=80=98main=E2=80=99: compat/check_asctime.c:15:5: error: too many arguments to function =E2=80=98asctime_r=E2=80=99 In file included from compat/check_asctime.c:8:0: /usr/include/time.h:266:14: note: declared here zsh: exit 1 gcc compat/check_asctime.c --- the posix-semantics way uses the 2-arg format.=20 The logic of the test setting in this file doesn't open to me. Why not test the same way as in getpwuid_r() case ? Tomi