Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 2E1F8431FDA for ; Tue, 24 Jan 2012 10:47:13 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id boY-9j+QlTKx for ; Tue, 24 Jan 2012 10:47:12 -0800 (PST) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id 91739431FB6 for ; Tue, 24 Jan 2012 10:47:12 -0800 (PST) Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) by fire-doxen-postvirus (Postfix) with ESMTP id E2818328063; Tue, 24 Jan 2012 10:47:07 -0800 (PST) X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new Received: from finestructure.net (DHCP-123-180.caltech.edu [131.215.123.180]) (Authenticated sender: jrollins) by fire-doxen-submit (Postfix) with ESMTP id 92BB132803F; Tue, 24 Jan 2012 10:47:00 -0800 (PST) Received: by finestructure.net (Postfix, from userid 1000) id 702172CE; Tue, 24 Jan 2012 10:47:00 -0800 (PST) From: Jameson Graef Rollins To: David Edmondson , notmuch@notmuchmail.org Subject: Re: [PATCH 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. In-Reply-To: <1327409620-10133-2-git-send-email-dme@dme.org> References: <1327052612-1040-1-git-send-email-dme@dme.org> <1327409620-10133-1-git-send-email-dme@dme.org> <1327409620-10133-2-git-send-email-dme@dme.org> User-Agent: Notmuch/0.11+102~g958863a (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Tue, 24 Jan 2012 10:46:57 -0800 Message-ID: <87k44hym3i.fsf@servo.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jan 2012 18:47:13 -0000 --=-=-= On Tue, 24 Jan 2012 12:53:38 +0000, David Edmondson wrote: > Instead, allow the caller to specify some parameters for the > button. Rework `notmuch-show-insert-part-multipart/signed' and > `notmuch-show-insert-part-multipart/encrypted' accordingly. Hi, David. I was thinking about this, and it seems to me that returning the button itself is useful. I can imagine in the future that it might be useful to be able to modify the button after you've created. Maybe it's inconvenient to specify all button parameters at creation time. Is there a reason it's really necessary to make this change? Can't callers just ignore the returned button if they don't care about it further? I can see that maybe it's nice to be able to specify parameters at creation time, but I'm not sure why that requires throwing out the returned object as well. jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJPHvyhAAoJEO00zqvie6q82G4P/2W+cnT/r8F4LCQbwj5x2jHH 8+6ZYI+/hqN0P130YfN6eP/g8tWyI9JUUmTda89cdyiTuka7kiD7IBNEl232cWPH UIbZGLS+otaSIz5X978jENSfwaXVn4l7R56u20b7X0MLv+EH2GE3oZZTI6oufS2k Abv6mK/BcfUrjwsswoUSGOUAP801H45eWnxWkHoYSmR28amMNlzw8dD+ql/BReX/ r2lRy0dVPRQ6a42MNKoIqivmWnVXanWffSVr/lTGnbgOCaa19uchqJXl1nSl6g4M OLVfJF5awm4Abeb//XkvRSkYkQnRlmIpnhTHbx52m2LiL7W+ggAJM2Gx2QRDAxXa 5J+hWVBOC3QJWxiaJG1cEMmekM0R6USGsHPgcU2YIEoLYeppMUeLTdNF0mN50Er2 nkNajTcPzA7zqP0aynAJQWjQsIyt62EkE2coga/z0LJew8xtuwfYsbGEpyxMeGaL ikHRRKp5qdo+fGUM6T+qyNp4mSonVPTtyD1w7hnyykax2u9V5tzOCCHVVrGT37qb ddJbBy/J1ueMm0FExHWAeM7xegSxJ5PhV/jjYL0vnFyW07A4QJIt5VAjeN++NmQ7 exqbvs8Q0wwpbYfASr81CDtHnAOK2GISlIPZ1PvgaXE9IajmYIxLDb0ugfgvWFWW FEC5oc12qGLMcb9DjcNb =g7Xa -----END PGP SIGNATURE----- --=-=-=--