From: Stewart Smith <stewart@flamingspork.com>
To: Carl Worth <cworth@cworth.org>, notmuch <notmuch@notmuchmail.org>
Subject: Re: [BUG] [PATCH] Fix appending of Received headers
In-Reply-To: <877h8tqkrp.fsf@yoom.home.cworth.org>
References: <878vu6ulev.fsf@flamingspork.com>
	<87ipszltyi.fsf@yoom.home.cworth.org>
	<877h8tqkrp.fsf@yoom.home.cworth.org>
User-Agent: Notmuch/0.5-215-g5143e5e (http://notmuchmail.org) Emacs/23.2.1
	(x86_64-pc-linux-gnu)
Date: Sat, 11 Jun 2011 12:36:41 +1000
Message-ID: <87fwnhw0ue.fsf@flamingspork.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Fri, 10 Jun 2011 17:22:50 -0700, Carl Worth <cworth@cworth.org> wrote:
Non-text part: multipart/signed
> On Tue, 24 May 2011 13:33:25 -0700, Carl Worth <cworth@cworth.org> wrote:
> > On Tue, 17 May 2011 12:10:32 +1000, Stewart Smith <stewart@flamingspork.com> wrote:
> > > We're not properly concatenating the Received headers if we parse them
> > > while requesting a header that isn't Received.
> ...
> > I'd prefer to fix the test suite here so that we don't later regress on
> > this behavior.
> 
> I've done that now. What the test suite was missing was having messages
> that actually had more than one Received header, (otherwise, no
> concatenation was ever used in the testing).
> 
> The new test and the patch are both now pushed.

Great and thanks! Sorry I didn't manage to get updating test suite to
the top of my TODO list.

-- 
Stewart Smith