Date: Fri, 20 Nov 2009 20:03:00 +0100
From: Adrian Perez de Castro <aperez@igalia.com>
To: notmuch@notmuchmail.org
Message-ID: <20091120200300.55ba8736@hikari>
In-Reply-To: <87lji11leu.fsf@yoom.home.cworth.org>
References: <935ead450911181000w2cddfe95qe9efd5bea9f9209d@mail.gmail.com>
	<20091119164543.25e7afe5@hikari>
	<935ead450911191823s776fda6eyb6f6949ac982bd03@mail.gmail.com>
	<87lji11leu.fsf@yoom.home.cworth.org>
Organization: Igalia
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAAXNSR0IArs4c6QAAADBQTFRFBwcHFhYWKCgoNzc3SEhIV1dXaGhod3d3iIiIlpaWqKiouLi4x8fH2NjY5+fn/v7+rSjDkgAAAjVJREFUOE9l07tvE0EQwOHfrkV9O+eko7g701BBfECJsIigT2IpooIqaSiRUEB0REj00FBQgYSCkhry+gecUPJybJeIxLumTbilsH2PMNXufDOa3ZVW+1JkpbUmD/8+vXR3c7or4Gz93mH309Kz8/C9/RQge7VfhW/LW+PF8IkrQ7Z6OKmQr1tl+LU/yWP9mxJka9O88fZHPwf/7u0kLyCnX3I4fQhgjAgIfi+HHw5A1Y2ggIMcFKAEnRoL0M3BosI4TI2IATjuT8DvSNJoNNJgkIhxlr9TUHeSpDnfohlIrMBlU+BGmsZqfr69FMfGMw4NoG835+J62riWyjQ/uXlTQjNUIoYegMsBM0pCD8oDas7n4HQsBghXFxJTW42KDs+4XLfjsN0wOYgABqARjMKIHIaAQnmHjsI5Cvi9Cf6k03OoWBkpIP3Q7354+dEimFBKHbMP9oKjwfd9gbrxR5KDToczK4uPF8UgNomKU2GaENRi77zyDKICxKBS4xXYbONPMQMdYZTBwMiMWiUg9g6UJ3OBogzjV8E7sBVwyvfAOYdQhsABzuOxI1MGZbs98Q6Md5UOfbbR2R0eWOesrnRw5ajT6f60LrNhWIHZpBnUWv2s14ukArWWTqTes3YQxRXgFkcMu70TPYqqUBs0YwmO967OVIdTG4bY4a7WLaqgLm5vbHdH5np0Dri//fmg7y8scB4u3+zsuNlH0X+g19bby69b+TYH6isvns8VdQWgxj9tHP8AR5/hSdYqkwsAAAAASUVORK5CYII=
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=PGP-SHA1;
	boundary="Sig_/_c1Cg6wI_1TUQe7AmijdlNP";
	protocol="application/pgp-signature"
Subject: Re: [notmuch] Segfault searching for tags
Precedence: list

--Sig_/_c1Cg6wI_1TUQe7AmijdlNP
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Fri, 20 Nov 2009 12:32:41 +0100, Carl wrote:

> On Thu, 19 Nov 2009 16:45:43 +0100, Adrian Perez de Castro <aperez@igalia=
.com> wrote:
> > The thing is that in notmuch_message_get_in_reply_to(), line 288, a NULL
> > instance of Xapian::TermIterator is dereferenced. In my particular case,
> > the culpript is a cache file of Claws-Mail, as seen in the following GDB
> > session:
>=20
> Not quite NULL, (nor is it quite dereferencing---this is nasty C++
> overloading), but yeah, the idea is the same. We need to protect all of
> our "calls" to this overloaded operator to not call it when the iterator
> is equal to the value returned by termlist_end ().

Well, of course you are right, it is an overloaded operator, which
(unfortunately, IMHO) looks like a pointer dereference. That is exactly
one of the things that I find more confusing about C++: it has features
like operator overloading which look cool initially, but that in the end
imply more complexity than needed. I can understand why you decided to
wrap Xapian with a plain C API :)
=20
> On Thu, 19 Nov 2009 20:23:15 -0600, Jeffrey Ollie <jeff@ocjtech.us> wrote:
> > I straced some of the crashes, and the last file that was read before
> > the crash was a malformed message.  I've attached one of the messages.
> >  I've been using offlineimap to sync my gmail mailbox to my laptop so
> > that I can use notmuch.  offlineimap isn't the most stable program,
> > but I'm not sure yet if offlineimap is causing the problem or if
> > that's the way the message is in gmail.
>=20
> Thanks for the file. I never like to push code that I haven't tested, so
> this was very helpful.
>=20
> Below is the patch that I just pushed which seems to do the trick.

I can confirm that this patch avoids the segfault in my case, too. Thanks
a lot for the quick fix.

Best regards,

--=20
Adrian Perez de Castro <aperez@igalia.com>
Igalia - Free Software Engineering

--Sig_/_c1Cg6wI_1TUQe7AmijdlNP
Content-Type: application/pgp-signature; name=signature.asc
Content-Disposition: attachment; filename=signature.asc

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.13 (GNU/Linux)

iEYEARECAAYFAksG5+QACgkQkcVZ2+TJEjuYSACcCC0Ciwqu7MG302myWPUO9jP0
YqUAnjnjz4N4Cbr7VAt7dkXJMzhjBeuR
=2teS
-----END PGP SIGNATURE-----

--Sig_/_c1Cg6wI_1TUQe7AmijdlNP--