To: Austin Clements <amdragon@MIT.EDU>, Jani Nikula <jani@nikula.org>
Subject: Re: [PATCH] emacs: create patch filename from subject for inline
	patch fake parts
In-Reply-To: <20111220215229.GF10376@mit.edu>
References: <1321657368-13872-1-git-send-email-jani@nikula.org>
	<87aa6nxb3o.fsf@nikula.org> <20111220215229.GF10376@mit.edu>
User-Agent: Notmuch/0.10.2+107~ga2d0215 (http://notmuchmail.org)
	Emacs/24.0.92.1 (x86_64-pc-linux-gnu)
From: David Edmondson <dme@dme.org>
Date: Wed, 21 Dec 2011 09:21:37 +0000
Message-ID: <cun4nwuxota.fsf@hotblack-desiato.hh.sledj.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: notmuch@notmuchmail.org
Precedence: list

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Tue, 20 Dec 2011 16:52:52 -0500, Austin Clements <amdragon@MIT.EDU> wrot=
e:
> Seems like a definite improvement, but perhaps a let* instead of all
> of the setq's?

What would be a lispy approach? I tried:

(defun notmuch-subject-to-patch-filename (subject)
  "Convert a typical patch mail subject line into a suitable filename."
  (concat=20
   (let ((filename subject)
	 (transforms
	  '(("^ *\\(\\[[^]]*\\]\\)? *" . "")
	    ("[. ]*$" . "")
	    ("[^A-Za-z0-9._-]+" . "-")
	    ("\\.+" . "."))))
     (mapc (lambda (transform)
	     (setq filename (replace-regexp-in-string (car transform) (cdr transfo=
rm) filename)))
	   transforms)
     (substring filename 0 (min (length filename) 50)))
   ".patch"))

...but that seems a bit unwieldy. `let*' looks best, but still feels a
bit odd:

(defun notmuch-subject-to-patch-filename (subject)
  "Convert a typical patch mail subject line into a suitable filename."
  (concat=20
   (let* ((filename (replace-regexp-in-string "^ *\\(\\[[^]]*\\]\\)? *" "" =
subject))
	  (filename (replace-regexp-in-string "[. ]*$" "" filename))
	  (filename (replace-regexp-in-string "[^A-Za-z0-9._-]+" "-" filename))
	  (filename (replace-regexp-in-string "\\.+" "." filename)))
     (substring filename 0 (min (length filename) 50)))
   ".patch"))

dme.
=2D-=20
David Edmondson, http://dme.org

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk7xpSEACgkQaezQq/BJZRYGGwCfQYZkbnDdCwCppuPST+dBrgn8
pqgAoIEdLro1vT+U8OnrcAnFIXve/osf
=NfGm
-----END PGP SIGNATURE-----
--=-=-=--