Date: Fri, 20 Jan 2012 11:39:03 -0500
From: Austin Clements <amdragon@MIT.EDU>
To: Thomas Jost <schnouki@schnouki.net>
Subject: Re: [PATCH v4 3/3] Update NEWS and INSTALL about gmime 2.6
Message-ID: <20120120163903.GY16740@mit.edu>
References: <87fwfaemuc.fsf@thor.loria.fr>
	<1327052365-20012-1-git-send-email-schnouki@schnouki.net>
	<1327052365-20012-3-git-send-email-schnouki@schnouki.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1327052365-20012-3-git-send-email-schnouki@schnouki.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: notmuch@notmuchmail.org
Precedence: list

Quoth Thomas Jost on Jan 20 at 10:39 am:
> ---
>  INSTALL |   12 ++++++------
>  NEWS    |    9 +++++++++
>  2 files changed, 15 insertions(+), 6 deletions(-)
> 
> diff --git a/INSTALL b/INSTALL
> index e51b397..bc98f1d 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -20,8 +20,8 @@ configure stage.
>  
>  Dependencies
>  ------------
> -Notmuch depends on three libraries: Xapian, GMime 2.4, and Talloc
> -which are each described below:
> +Notmuch depends on three libraries: Xapian, GMime 2.4 or 2.6, and
> +Talloc which are each described below:
>  
>  	Xapian
>  	------
> @@ -39,14 +39,14 @@ which are each described below:
>  	reading mail while notmuch would wait for Xapian when removing
>  	the "inbox" and "unread" tags from messages in a thread.
>  
> -	GMime 2.4
> -	---------
> -	GMime 2.4 provides decoding of MIME email messages for Notmuch.
> +	GMime 2.4 or 2.6
> +	----------------
> +	GMime provides decoding of MIME email messages for Notmuch.
>  
>  	Without GMime, Notmuch would not be able to extract and index
>  	the actual text from email message encoded as BASE64, etc.
>  
> -	GMime 2.4 is available from http://spruce.sourceforge.net/gmime/
> +	GMime is available from http://spruce.sourceforge.net/gmime/
>  
>  	Talloc
>  	------
> diff --git a/NEWS b/NEWS
> index 6afa912..e78472c 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -36,6 +36,15 @@ New functions
>    notmuch_query_add_tag_exclude supports the new tag exclusion
>    feature.
>  
> +Build fixes
> +-----------
> +
> +Compatibility with GMime 2.6
> +
> +  It is now possible to build notmuch against both GMime 2.4 and 2.6.
> +  However they may be some issues in PGP signature verification

Typo and comma: "However, there".  It would be good to describe the
bug, lest people hold off on upgrading because they think it's
something more dire.  Maybe

"However, a bug in current GMime 2.6 causes notmuch not to report
signatures where the signer key is unavailable (GNOME bug 668085)."

> +  because of a bug in current versions of GMime 2.6.
> +
>  Notmuch 0.11 (2012-01-13)
>  =========================
>