From: Michal Sojka <sojkam1@fel.cvut.cz>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/3] emacs: Fix mail composition under Emacs 23
In-Reply-To: <8760z8ah7e.fsf@zancas.localnet>
References: <1451753265-26713-1-git-send-email-sojkam1@fel.cvut.cz>
 <1451753265-26713-2-git-send-email-sojkam1@fel.cvut.cz>
 <8760z8ah7e.fsf@zancas.localnet>
User-Agent: Notmuch/0.21+30~g55c056a (http://notmuchmail.org) Emacs/24.5.1
 (x86_64-pc-linux-gnu)
Date: Wed, 06 Jan 2016 22:27:46 +0100
Message-ID: <87ziwiv1nx.fsf@steelpick.2x.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list

On Tue, Jan 05 2016, David Bremner wrote:
> Michal Sojka <sojkam1@fel.cvut.cz> writes:
>
>> +    (when return-action (nconc args '(return-action)))
>> +    (apply 'message-setup-1
>> +	   ;; The following sexp is copied from `message-mail'
>
>> +	   (nconc
>> +	    `((To . ,(or to "")) (Subject . ,(or subject "")))
>
> I missed this the first time, but I a bit worried about this used of
> nconc. It seems to fall under "A common pitfall is to use a quoted
> constant list as a non-last argument to =E2=80=98nconc=E2=80=99"  (from t=
he elisp
> manual).  In any case it's not really performance critical code (I
> guess?) so maybe we could just use append?

Yes, this make sense. As the nconc is already in master, I'll not
combine the fix for this with 1/3, but I'm sending a separate patch that
applies after 3/3.

-Michal