From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Robin Green <greenrd@greenrd.org>, Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: Preventing the user shooting themself in the foot
In-Reply-To: <86iproe86u.fsf@greenrd.plus.com>
References: <86iproe86u.fsf@greenrd.plus.com>
User-Agent: Notmuch/0.5-292-gaa2fa19 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Wed, 29 Jun 2011 13:37:21 -0700
Message-ID: <87fwmsxtku.fsf@servo.factory.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: list

--=-=-=

On Wed, 29 Jun 2011 20:42:01 +0100, Robin Green <greenrd@greenrd.org> wrote:
> It's really dangerous to use the 'a' key in notmuch-mode in an inbox
> thread which has multiple unread replies! Yes, the other unread replies
> will still be tagged unread, but the user might not immediately be aware
> of them. It would be really useful to have an optional warning ("More
> unread messages in this thread, are you sure?") for this situation!

I think that's a bit extreme, but I agree that the default behavior of
the emacs key bindings are not good, particularly in regards to
archiving messages.

I should probably just send in all of my emacs UI tweaks as patches, but
here are a couple of functions/bindings I've added to my .emacs to make
the message processing more sane.  The main new function is
notmuch-show-next-open-message-or-pop, which will jump to the next
message in the thread, or pop out of the thread if you're on the last
message.  I then use this in my tag processing functions, such as
archiving and deleting.

hth.

jamie.


(defun notmuch-show-next-open-message-or-pop ()
  "Show the next message or pop to parent search."
  (interactive)
  (let (r)
    (while (and (setq r (notmuch-show-goto-message-next))
		(not (notmuch-show-message-visible-p))))
    (if r
	(progn
	  (notmuch-show-mark-read)
	  (notmuch-show-message-adjust))
      (let ((parent-buffer notmuch-show-parent-buffer))
	(if parent-buffer
	    (progn
	      (kill-this-buffer)
	      (switch-to-buffer parent-buffer)
	      (forward-line 1)))))))

(define-key notmuch-show-mode-map "a"
  (lambda ()
    "Archive current message and advance."
    (interactive)
    (notmuch-show-remove-tag "inbox")
    (notmuch-show-next-open-message-or-pop)))

(define-key notmuch-show-mode-map "d"
  (lambda ()
    "Delete current message and advance to next message."
    (interactive)
    (notmuch-show-add-tag "delete")
    (notmuch-show-next-open-message-or-pop)))

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJOC40CAAoJEO00zqvie6q88eUP+gPzsSfg9ch7WjKrAjoFKMCJ
zL//KI8JVx4uw0+QhIKatfnlPPvjMBeMDtCDyHUocxBvEsnDxS16X2fs8pCy0jya
TY31yQYmudn+c9WuAJtGQUfcpMHOLzWROQISRH/y1dJD1JzON52cRGY+LNxXx9Qa
SElCkP0+TD3A4lLqiFJ/nLeFdz00CJ4r1DMkeLbo3qpLPLr5emK3G5ysgEv07RzU
D2ohdMJlUU3FM138brSTIgK570P295vyFuroOMBeuYVqIjH/GtUQIiOxy8PpMHsv
VccbUOBVT4ol3evnJJh+feDjkeGy8+3PF91ERqCAsvRBfl6/1UyI+3ju5Ao91OgG
Q0pehPZGBBB3wxUyX6m6hvdOXvkc2vVba9a3GDnDmo53hqv69J2n+7roJeqSaNvj
TntZ/DQSBRQG6ZrOt+BjSkJPQn3j5j4qCvjc/jfBVArfdOAPGXGMGH1ICDmUKHvM
G+R756JoyD+Ro27dhcWvE0qzE2xi7NPM0M6GBRsZQRSBfJ45gwxH45+N4jNi8U3v
Q2AMUohppIouoxwZgk11XyxdYD5EdM0Nc87BSJwpfRlXoq+Uf9r+jzVYzswiITn4
r8IXCFruts5Md1McZPK7wU+nnMX8B73772XsNgiHPE0wiG/Z91sOY85RLSzDrXCa
a4OY+Hez4nSH/PLTM8Ac
=1Pef
-----END PGP SIGNATURE-----
--=-=-=--