From: Tomi Ollila <tomi.ollila@iki.fi>
To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
Subject: Re: [PATCH v3 09/10] cli: address: Add --output=count
In-Reply-To: <1415147159-19946-10-git-send-email-sojkam1@fel.cvut.cz>
References: <1415147159-19946-1-git-send-email-sojkam1@fel.cvut.cz>
	<1415147159-19946-10-git-send-email-sojkam1@fel.cvut.cz>
User-Agent: Notmuch/0.18.2+169~g5bcdd1c (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
Date: Wed, 05 Nov 2014 22:57:54 +0200
Message-ID: <m21tph1i25.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Wed, Nov 05 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:

> This output prints how many times was each address encountered during
> search.
> ---
> [ nn lines removed]
>
>      ``--sort=``\ (**newest-first**\ \|\ **oldest-first**)
>          This option can be used to present results in either
>          chronological order (**oldest-first**) or reverse chronological
> @@ -56,6 +63,8 @@ Supported options for **address** include
>          By default, results will be displayed in reverse chronological
>          order, (that is, the newest results will be displayed first).
>  
> +	This option has no effect when used with --output=count.

This is not entirely true -- the order the addresses are gathered will
affect how the hash table is built up and it may affect how the addresses
are printed (unless the --sort option is ignored when --count is given,
which does not seem to be the case). 

The question is whether the accuracy of this message matters; some
nitpickers might complain ;)

Anyway, +1 from me to patches 1 - 9 -- these things could still be
adjusted when NEWS patch of the feature is prepared.


Tomi