Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id C5964429E26 for ; Wed, 15 Jun 2011 04:11:55 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DqO4Jyw3zVEW for ; Wed, 15 Jun 2011 04:11:55 -0700 (PDT) Received: from mail-fx0-f53.google.com (mail-fx0-f53.google.com [209.85.161.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id DF5CF431FB6 for ; Wed, 15 Jun 2011 04:11:54 -0700 (PDT) Received: by fxm8 with SMTP id 8so337389fxm.26 for ; Wed, 15 Jun 2011 04:11:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:date:message-id:x-mailer; bh=xasTdWsfbhyEjAIEc4wu/WeEENixD2ZXgkCiF2JvD/Y=; b=s3NmnrzMG6VBBumEpW+Et6PQjwEodQP7pSorp78Gr+/pBSIT5C+GXAeDe5RcU2q9Av QEvPfOPLsO2wt+4tobgSJGgYiBm0ityDSWdmsYf4PAl4lq5BX6D8i2HHGUvM3VOOgy6O 790aHc71fhCacw/GexfvgOPxdwBplwr+qSp8w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=v1w7/DC7PQ7MBoK70KkiunGa7YxMm/raDXVBOKV3SNNDdm9Jb0vV+uva2ImC3o1BLa 0+xkdSkdZRzoZXF9ZxWzstMXvMAZ/6kjRPISdoKvBCo2MwHHviN0SOrNW6UCJsgpFOvU +m0immVyqHxav1vTTEr8NdCeJ/+2jNMOgqIIs= Received: by 10.223.159.14 with SMTP id h14mr452325fax.20.1308136313457; Wed, 15 Jun 2011 04:11:53 -0700 (PDT) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id b26sm162051fak.0.2011.06.15.04.11.51 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 15 Jun 2011 04:11:52 -0700 (PDT) From: Dmitry Kurochkin To: notmuch@notmuchmail.org Subject: [PATCH 1/3] Fix double free in guess_from_received_header(). Date: Wed, 15 Jun 2011 15:12:12 +0400 Message-Id: <1308136334-9219-1-git-send-email-dmitry.kurochkin@gmail.com> X-Mailer: git-send-email 1.7.5.4 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2011 11:11:55 -0000 Before the change, the last loop in guess_from_received_header() did not reset domain and tld variables to NULL. This leads to double free error in some cases and possibly other bugs. --- notmuch-reply.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/notmuch-reply.c b/notmuch-reply.c index 514bbc6..dab69e6 100644 --- a/notmuch-reply.c +++ b/notmuch-reply.c @@ -406,6 +406,7 @@ guess_from_received_header (notmuch_config_t *config, notmuch_message_t *message /* Now extract the last two components of the MTA host name * as domain and tld. */ + domain = tld = NULL; while ((ptr = strsep (&token, delim)) != NULL) { if (*ptr == '\0') continue; -- 1.7.5.4