From: Austin Clements <aclements@csail.mit.edu>
To: david@tethera.net, notmuch@notmuchmail.org
Subject: Re: [Patch v2 04/11] perf-test: optionally print description for each
	group of tests
In-Reply-To: <1354762908-5788-5-git-send-email-david@tethera.net>
References: <1354762908-5788-1-git-send-email-david@tethera.net>
	<1354762908-5788-5-git-send-email-david@tethera.net>
User-Agent: Notmuch/0.14+159~g6895fee (http://notmuchmail.org) Emacs/23.4.1
	(i486-pc-linux-gnu)
Date: Mon, 10 Dec 2012 23:31:15 -0500
Message-ID: <87lid5nrak.fsf@awakening.csail.mit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: David Bremner <bremner@debian.org>
Precedence: list

On Wed, 05 Dec 2012, david@tethera.net wrote:
> From: David Bremner <bremner@debian.org>
>
> Output from tests is indented slightly in the same style as the
> correctness tests.
> ---
>  performance-test/perf-test-lib.sh |    9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/performance-test/perf-test-lib.sh b/performance-test/perf-test-lib.sh
> index e399d3f..415bf15 100644
> --- a/performance-test/perf-test-lib.sh
> +++ b/performance-test/perf-test-lib.sh
> @@ -67,12 +67,12 @@ add_email_corpus ()
>  }
>  
>  print_header () {
> -    printf "[v%4s %6s]        Wall(s)\tUsr(s)\tSys(s)\tRes(K)\tIn/Out(512B)\n" \
> +    printf "[v%4s %6s]          Wall(s)\tUsr(s)\tSys(s)\tRes(K)\tIn/Out(512B)\n" \
>  	   ${PERFTEST_VERSION} ${corpus_size}
>  }
>  
>  time_run () {
> -    printf "%-22s" "$1"
> +    printf "  %-22s" "$1"
>      if test "$verbose" != "t"; then exec 4>test.output 3>&4; fi
>      if ! eval >&3 "/usr/bin/time -f '%e\t%U\t%S\t%M\t%I/%O' $2" ; then
>  	test_failure=$(($test_failure + 1))
> @@ -92,3 +92,8 @@ time_done () {
>  
>  cd -P "$test" || error "Cannot setup test environment"
>  test_failure=0
> +
> +if [[ -n "test_description" ]]; then

I think you meant "$test_description".  Though, it seems like it would
be confusing if $test_description wasn't set and there was no output.
Maybe this shouldn't be conditional and below should be
${test_description:-UNNAMED} or something?

> +    echo
> +    echo $(basename "$0"): "Benchmarking ${test_description}"
> +fi
> -- 
> 1.7.10.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch