Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 6F8F2431FB6 for ; Mon, 16 Jan 2012 10:39:26 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9jOzW9jvPw9D for ; Mon, 16 Jan 2012 10:39:25 -0800 (PST) Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id ADAF5431FAF for ; Mon, 16 Jan 2012 10:39:25 -0800 (PST) Received: by wibhr12 with SMTP id hr12so2719751wib.26 for ; Mon, 16 Jan 2012 10:39:24 -0800 (PST) Received: by 10.180.93.193 with SMTP id cw1mr22349946wib.5.1326739164413; Mon, 16 Jan 2012 10:39:24 -0800 (PST) Received: from hotblack-desiato.hh.sledj.net (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) by mx.google.com with ESMTPS id fq7sm23349833wbb.1.2012.01.16.10.39.22 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 16 Jan 2012 10:39:23 -0800 (PST) Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) id 2ACEBA0397; Mon, 16 Jan 2012 18:39:21 +0000 (GMT) To: Dmitry Kurochkin , notmuch Subject: Re: [PATCH 2/2] test: Add tests for `notmuch-show-test-clean-address'. In-Reply-To: <87k44r8s0a.fsf@gmail.com> References: <1326732453-23377-1-git-send-email-dme@dme.org> <1326732453-23377-2-git-send-email-dme@dme.org> <87k44r8s0a.fsf@gmail.com> User-Agent: Notmuch/0.11+64~g42e8f66 (http://notmuchmail.org) Emacs/24.0.92.1 (x86_64-pc-linux-gnu) From: David Edmondson Date: Mon, 16 Jan 2012 18:39:14 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jan 2012 18:39:26 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Mon, 16 Jan 2012 21:41:09 +0400, Dmitry Kurochkin wrote: > On Mon, 16 Jan 2012 16:47:33 +0000, David Edmondson wrote: > > --- > >=20 > > Add three tests. The third one currently fails. > >=20 >=20 > I do not like that we add testing code to emacs/ folder. My > understanding is that files in emacs/ are all intended to be installed > on the system. But tests should not be. Can we move this file to > tests/? >=20 > Also, one file for all tests is a mess. Let's write more smaller files > that test different features instead of putting everything to one > bloated file. Like we do for other tests now. >=20 > I like the idea of putting elisp testing code into .el files and calling > functions from regular tests (that is why I added test-lib.el). For > tests implemented in elisp, I propose adding a pair of files, e.g.: >=20 > tests/emacs-address.sh - tests that call elisp functions > tests/emacs-address.el - elisp code that actually implements the tests >=20 > What do you think? All good suggestions - I'll re-whack it. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk8UbtIACgkQaezQq/BJZRbEqQCfZma2HInICfzrIK7rX63JCvPN U28An2HBNqyYuBcfyPHuCE/MvoNSwT1h =m6o2 -----END PGP SIGNATURE----- --=-=-=--