From: Jameson Graef Rollins <jrollins@finestructure.net>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/3] reworked crypto toggle, plus a couple of other
 toggles
In-Reply-To: <1327486729-18052-1-git-send-email-dme@dme.org>
References: <1327486729-18052-1-git-send-email-dme@dme.org>
User-Agent: Notmuch/0.11+131~g7337d96 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Sun, 29 Jan 2012 12:06:57 -0800
Message-ID: <87ehuiz31a.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: list

--=-=-=

On Wed, 25 Jan 2012 10:18:46 +0000, David Edmondson <dme@dme.org> wrote:
> The crypto toggle previously worked using an argument to
> `notmuch-show' and various other functions and relied on killing and
> re-creating the notmuch-show-mode buffer. Various other
> pseudo-buffer-local variables were present based on an ad-hoc scheme.
>
> Replace the ad-hoc scheme with real buffer-local variables and then
> update `notmuch-show-refresh-view' to erase and re-paint rather than
> kill and re-create. Update the crypto switch accordingly.

Hey, David.  Thank you so much for this!  I was really hoping someone
would eventually pick this up, and your solution is great!  This new
behavior is *much* nicer.  I really like it.

I haven't done a full code review, though, just tested it out.  I may
not be able to get to it for a while, so please don't hold this patch up
on my account).

> Add two other toggles:
>     - whether non-matching messages are available,
>     - the indentation of message contents.
> Both of these default to the current behaviour.

These new features enabled by this are very cool!  I love them both.  I
bet there are other interesting toggle features that could be enabled by
this.

> My inclination is to remove `notmuch-crypto-process-mime' altogether
> (declared it an obsolete variable) and allow users to set a default
> for `notmuch-show-process-crypto' directly, but that is not done in
> this patchset while awaiting feedback.

I'm not sure I understand this.  `notmuch-show-process-crypto' *is* what
sets the default for the `notmuch-show-process-crypto' buffer-local
variable.  How would you change the current behavior or settings (beyond
just a variable rename)?

> `notmuch-crypto-process-mime' is used only in notmuch-show.el, so the
> setting really belongs there with an appropriate name.

I intentionally put this in a separate section in case there were
eventually other needs for this setting beyond just show mode.  I
personally think we should just leave it where it is, particularly since
it's been there for a while.

jamie.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJPJabhAAoJEO00zqvie6q8+TQQAIqrSKxjk+j6XQVfw7ZKg6eo
UHLy5BCh3I3NLwwSIf5lZR5OSUBOQQZ9qZ1dP8j4IwTWr88uq2OKR15HDqXr3453
/OCu9HooirzBQN1THjOTusLsPz1gVlO3aEocNGEbFLHk5Ms9C3EcHdjrL4lqtv2s
mSUBHKfUXSsnZSwqVqsUjRkgluKYZOP7o+aM3OEiSNt4lMIsBNsQdxv55vDcfhqS
TsWXpH1ZsD8T6kNFteRA6MjVjYbEgFqstPx3x6GJ6rJroTYSI2+7O25FanFLG9to
3/A7r/53f5R5WJOPvGCEnw3Uv4Df5wP5kJpDWXKzzk9gJAK6s8lxBoSSheQZwdIJ
RqMy9cImoFotOsDYmKCXdpMUxna45IN8t+zeE7Zpo2e6WU/TZnYKPGDJTi1g04Fq
xx2gdHbL5by451EHKrGUhAG6yc/sSfOWScbF3PgS/5+2r3qinSiMpnDvBSr7PUO1
cRNCQOsu7WHeBwCd0vjAMrSzaWYFtjObDue/EPaBN5qC9KAvVzk06NorJcKi4GwE
T9ZlF1SKpNhE3wq92agsM4L+KERpAXeYpxFIJdTAIICLcVMEBScnJ6eG4kmp8ROZ
ADt1mn/Cyp2OPsjpituhAeynSCtshNreoJbpEvyvkXrU19HXv3AGDi92sz/UWVEA
FB0eVmzZW8IwGN41g6W+
=FTt5
-----END PGP SIGNATURE-----
--=-=-=--