Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id D3DF6431FB6 for ; Fri, 4 Nov 2011 13:21:48 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.699 X-Spam-Level: X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GePsd+yVDyxs for ; Fri, 4 Nov 2011 13:21:48 -0700 (PDT) Received: from mail-qy0-f174.google.com (mail-qy0-f174.google.com [209.85.216.174]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id AA05B429E26 for ; Fri, 4 Nov 2011 13:21:45 -0700 (PDT) Received: by qyk27 with SMTP id 27so1499913qyk.5 for ; Fri, 04 Nov 2011 13:21:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=GCj6QoV3Su789/gXHH9eZ4tPjbxmfu00udX8EZ1Qerw=; b=W+vf3SprEv8vfUmQKACRfj6U0OuH7A0AB51xlrhEHTf4Xz/cjUcWSV9y6hM2MsrJ0x sYd8Tule7GkLp8JKn280KA/eXbJ/Ca+XAeu36QjD8dPHBqD3QC++qQq97FgK+iuHL+XM 52b8V/jhn7TkkWJeaF8E41zm+3yfB7Tcx5X90= MIME-Version: 1.0 Received: by 10.42.144.65 with SMTP id a1mr17768954icv.46.1320438103538; Fri, 04 Nov 2011 13:21:43 -0700 (PDT) Sender: amdragon@gmail.com Received: by 10.143.166.17 with HTTP; Fri, 4 Nov 2011 13:21:43 -0700 (PDT) In-Reply-To: <87obwwlsqo.fsf@nikula.org> References: <87fwi86dky.fsf@servo.finestructure.net> <87obwwlsqo.fsf@nikula.org> Date: Fri, 4 Nov 2011 16:21:43 -0400 X-Google-Sender-Auth: EP7Y7BZOE58qzzEWKjS9EVVN0LY Message-ID: Subject: Re: [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results From: Austin Clements To: Jani Nikula Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Nov 2011 20:21:49 -0000 On Mon, Oct 31, 2011 at 6:07 PM, Jani Nikula wrote: > On Mon, 31 Oct 2011 14:44:29 -0700, Jameson Graef Rollins wrote: >> In order to push forward with this, though, I think we really need to >> have a complete unit test for this new functionality. =A0We usually like >> to see units tests that describe and then test for the new functionality >> you wish to add, followed by the patches that provide the new >> functionality. =A0Lots of good tests for new functionality being propose= d >> here shouldn't be too difficult to work out ahead of time. > > Right. I'd just like to make sure the approach I've taken (particularly > patch 1 in the set as it touches the lib) is acceptable before spending > time on testing and documentation etc. Indeed patches 1 and 2 changed > fundamentally between v1 and v2 after some chats on IRC. If the comments > now are favourable, I'll write the tests and documentation. (Though I > guess I have to admit the tests would've been beneficial to me already > now...) The library interface looks perfectly reasonable and consistent to me. My only concern would be that there's no way to return errors from notmuch_query_count_threads, but notmuch_query_count_messages has exactly the same problem. Other than that, you missed a few spaces before parentheses.