From: Michal Sojka <sojkam1@fel.cvut.cz>
To: Carl Worth <cworth@cworth.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] test: Better handling of stdout and stderr
In-Reply-To: <8739r8bt9u.fsf@yoom.home.cworth.org>
References: <1289346035-24904-1-git-send-email-sojkam1@fel.cvut.cz>
	<87k4kkq3r2.fsf@yoom.home.cworth.org>
	<8739r8bt9u.fsf@yoom.home.cworth.org>
User-Agent: Notmuch/0.5-11-g48b5e00 (http://notmuchmail.org) Emacs/23.2.1
	(x86_64-pc-linux-gnu)
Date: Sun, 14 Nov 2010 22:52:20 +0100
Message-ID: <87hbfjr2sr.fsf@steelpick.2x.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Thu, 11 Nov 2010, Carl Worth wrote:
> Oh, and one other thing I forgot to mention about the patch. It
> currently talks about things along the lines of "git-style tests" and
> "cworth-style tests".
> 
> You and I might understand perfectly well what that means now, but we
> need the test suite to be independently comprehensible. (I'd like to be
> able to understand it myself when I look at it again in the future,
> having forgotten the current history.)
> 
> So if you could describe these instead as something like "tests using
> test_expect_success" vs. "tests using
> test_begin_subtest/test_expect_equal" or something like that, that would
> be great.

Hi Carl,

I'm sending the fixes to the test suite as responses to this mail.

-Michal