From: Michal Sojka <sojkam1@fel.cvut.cz>
To: Sebastian Spaeth <Sebastian@SSpaeth.de>, David A Benjamin
	<davidben@MIT.EDU>, Ben Gamari <bgamari.foss@gmail.com>
In-Reply-To: <87k4thplxj.fsf@SSpaeth.de>
References: <4b990b7b.0e67f10a.073c.0686@mx.google.com>
	<alpine.DEB.1.10.1003111748020.9755@dr-wily.mit.edu>
	<87eijqlz54.fsf@steelpick.localdomain> <877hphtx6h.fsf@SSpaeth.de>
	<87fx45eg55.fsf@steelpick.localdomain> <87k4thplxj.fsf@SSpaeth.de>
Date: Sun, 14 Mar 2010 19:15:45 +0100
Message-ID: <87mxyabwha.fsf@steelpick.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: notmuch <notmuch@notmuchmail.org>
Subject: Re: [notmuch] Notmuch command interface
Precedence: list

On Fri, 12 Mar 2010 17:03:04 +0100, "Sebastian Spaeth" <Sebastian@SSpaeth.de> wrote:
> On Fri, 12 Mar 2010 16:03:34 +0100, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> > On Fri, 12 Mar 2010, Sebastian Spaeth wrote:
> > > > Unfortunately, I didn't make much progress in implementating this, but
> > > > it's definitely a priority for me because I want to get rid of slow
> > > > notmuchsync.
> > > 
> > > notmuchsync master is now using the json output, by the way. I think
> > > that suppressing the output of msg bodies in notmuch show will help
> > > notmuchsync performance *a lot*.
> > 
> > I've just tried it :-(
> >   File "/usr/lib/pymodules/python2.5/simplejson/decoder.py", line 353, in raw_decode
> >     raise ValueError("No JSON object could be decoded")
> > ValueError: No JSON object could be decoded
> 
> Wow, that is bad. All it does is taking "nomuch show" output and feeding
> it to the json parser. That probably means that the json was not valid
> (which would be bad).

Yes. I found that the problem is caused by emails with an empty body.
I'll post a patch to fix this in a while.

> Having said that, I remember that I got that when I used a notmuch that
> doesn't include the notmuch tags in the json output, ie you need notmuch
> from current master less than 26h ago. Do you use that?
> 
> Also Python 2.6 is a requirement, but I see you used that already...

Strange, I use default python from Debian which is 2.5.5 and current
notmuchsync master runs without problems.

-Michal