From: Pieter Praet <pieter@praet.org>
To: David Bremner <david@tethera.net>
Subject: Re: [PATCH] test: cli: getting/setting/removing config values
In-Reply-To: <87boq8nu9f.fsf@zancas.localnet>
References: <87y5tckf1y.fsf@praet.org>
	<1326389401-20468-1-git-send-email-pieter@praet.org>
	<87boq8nu9f.fsf@zancas.localnet>
User-Agent: Notmuch/0.10.2+115~gadd29f6 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-unknown-linux-gnu)
Date: Sat, 14 Jan 2012 09:54:59 +0100
Message-ID: <8739bir7do.fsf@praet.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Precedence: list

On Thu, 12 Jan 2012 23:42:04 -0400, David Bremner <david@tethera.net> wrote:
> On Thu, 12 Jan 2012 18:30:01 +0100, Pieter Praet <pieter@praet.org> wrote:
> > Should have come before commit 1df71b55
> 
> This doesn't seem like an especially helpful commit
> message. Editorializing is ok, I guess, but maybe keep it below the
> '---' ?
> 

You're right.  The message I was trying to convey (quite tersely),
was that these tests were written in response to commit 1df71b55
(and should probably be retroactively ran on 1df71b55~1).

I realize now that it could potentially be wrongly interpreted as
criticism of sorts, which of course wasn't my intention.

Anyways, I ran the tests on both 1df71b55~1 and 1df71b55, and
-as expected- everything checks out fine.

Amended patch follows.

> d


Peace

-- 
Pieter