Return-Path: <markwalters1009@gmail.com>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id E16D9431FDF
	for <notmuch@notmuchmail.org>; Tue,  2 Sep 2014 05:31:00 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0.201
X-Spam-Level: 
X-Spam-Status: No, score=0.201 tagged_above=-999 required=5
	tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
	FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001,
	RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id JEO38buxUjSj for <notmuch@notmuchmail.org>;
	Tue,  2 Sep 2014 05:30:55 -0700 (PDT)
Received: from mail-we0-f172.google.com (mail-we0-f172.google.com
	[74.125.82.172]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 3D00F431FD2
	for <notmuch@notmuchmail.org>; Tue,  2 Sep 2014 05:30:55 -0700 (PDT)
Received: by mail-we0-f172.google.com with SMTP id q59so6886232wes.31
	for <notmuch@notmuchmail.org>; Tue, 02 Sep 2014 05:30:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=from:to:cc:subject:date:message-id;
	bh=sHyZNKiIhoxIoGuHYtTk2j3+e5nJOsyhlKAF8fW2qVU=;
	b=vG6D2cntY3SwC0xPytP0cyodH/TGf2uIVjV0THL/osm7qF0nScNRk52ehp+4i2O5FV
	XVcX8F3L49eR9UmIKxl4k9aWDa8UA5xqQASF48C18ccocRFQvG1MgAIQZ53AJ6gRg5oz
	KncFBAr1AE3Bm2lp+TRHPxByahWqgd0Mp0Cw3syXAfvmdTdnJeQaPKR6s72B0OovIYlp
	8MGxTA0FJgpYQ3C/TYrVHauGAoDajg9WM1EHHBO+8NDm6CM21pRkh1YrAtR++ot9LVAA
	dKGh2yw9aMOP3pCgYVdyzJzEGC/hSrAwx3LbBlC6zTB3c9VA729AEqDYxp4xA1XAP2yU
	CT7A==
X-Received: by 10.194.63.205 with SMTP id i13mr15999822wjs.74.1409661053875;
	Tue, 02 Sep 2014 05:30:53 -0700 (PDT)
Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162])
	by mx.google.com with ESMTPSA id n5sm9172874wja.38.2014.09.02.05.30.52
	for <multiple recipients>
	(version=TLSv1.2 cipher=RC4-SHA bits=128/128);
	Tue, 02 Sep 2014 05:30:53 -0700 (PDT)
From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH] emacs: jump: sort-order bugfix
Date: Tue,  2 Sep 2014 13:30:49 +0100
Message-Id: <1409661049-23417-1-git-send-email-markwalters1009@gmail.com>
X-Mailer: git-send-email 1.7.10.4
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Sep 2014 12:31:01 -0000

default-value needs its argument to be quoted.
---

Slightly strangely default-value of 't or nil is 't or nil
respectively so the code didn't give an error but just did the wrong
thing.

Thanks to Jani for finding the bug.

Best wishes

Mark

 emacs/notmuch-jump.el |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/emacs/notmuch-jump.el b/emacs/notmuch-jump.el
index 5eb0949..0193f8c 100644
--- a/emacs/notmuch-jump.el
+++ b/emacs/notmuch-jump.el
@@ -51,7 +51,7 @@ (defun notmuch-jump-search ()
 		 (case (plist-get saved-search :sort-order)
 		   (newest-first nil)
 		   (oldest-first t)
-		   (otherwise (default-value notmuch-search-oldest-first)))))
+		   (otherwise (default-value 'notmuch-search-oldest-first)))))
 	    (push (list key name
 			`(lambda () (notmuch-search ',query ',oldest-first)))
 		  action-map)))))
-- 
1.7.10.4