Return-Path: <tomi.ollila@iki.fi>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 38989431FBD
	for <notmuch@notmuchmail.org>; Sun, 15 Sep 2013 01:36:29 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id J4s1Gt4ioJZA for <notmuch@notmuchmail.org>;
	Sun, 15 Sep 2013 01:36:25 -0700 (PDT)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
	by olra.theworths.org (Postfix) with ESMTP id 92645431FAE
	for <notmuch@notmuchmail.org>; Sun, 15 Sep 2013 01:36:25 -0700 (PDT)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
	by guru.guru-group.fi (Postfix) with ESMTP id 7B2E61000B2;
	Sun, 15 Sep 2013 11:36:19 +0300 (EEST)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] contrib: pick: bugfix use of mini-buffer history
In-Reply-To: <1379233173-9812-1-git-send-email-markwalters1009@gmail.com>
References: <1379233173-9812-1-git-send-email-markwalters1009@gmail.com>
User-Agent: Notmuch/0.16+77~g2561895 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Sun, 15 Sep 2013 11:36:19 +0300
Message-ID: <m2li2ya3cs.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Sep 2013 08:36:29 -0000

On Sun, Sep 15 2013, Mark Walters <markwalters1009@gmail.com> wrote:

> pick was meant to use the same mini-buffer history but this failed
> because the interactive definition took place before the use search
> mini-buffer history part. Remove the interactive prompt to ensure the
> correct history is used.
> ---

LGTM.

Tomi

>  contrib/notmuch-pick/notmuch-pick.el |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
> index 01ca4bd..ad85d03 100644
> --- a/contrib/notmuch-pick/notmuch-pick.el
> +++ b/contrib/notmuch-pick/notmuch-pick.el
> @@ -948,7 +948,7 @@ The arguments are:
>    BUFFER-NAME: the name of the buffer to show the pick tree. If
>        it is nil \"*notmuch-pick\" followed by QUERY is used.
>    OPEN-TARGET: If TRUE open the target message in the message pane."
> -  (interactive "sNotmuch pick: ")
> +  (interactive)
>    (if (null query)
>        (setq query (notmuch-read-query "Notmuch pick: ")))
>    (let ((buffer (get-buffer-create (generate-new-buffer-name
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch