Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id AD3BE431FAF for ; Sat, 24 Nov 2012 17:18:29 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a4iOsTL3HsNQ for ; Sat, 24 Nov 2012 17:18:29 -0800 (PST) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 01154431FAE for ; Sat, 24 Nov 2012 17:18:29 -0800 (PST) Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net ([156.34.89.108] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1TcQrb-0006fr-P3; Sat, 24 Nov 2012 21:18:27 -0400 Received: from bremner by zancas.localnet with local (Exim 4.80) (envelope-from ) id 1TcQrB-0005l8-84; Sat, 24 Nov 2012 21:18:01 -0400 From: David Bremner To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [Patch v2 09/17] tag-util.[ch]: New files for common tagging routines In-Reply-To: References: <1353792017-31459-1-git-send-email-david@tethera.net> <1353792017-31459-10-git-send-email-david@tethera.net> User-Agent: Notmuch/0.14+75~g984212d (http://notmuchmail.org) Emacs/24.1.1 (x86_64-pc-linux-gnu) Date: Sat, 24 Nov 2012 21:18:01 -0400 Message-ID: <87fw3ywkdy.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-Spam_bar: - X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Nov 2012 01:18:29 -0000 > > Maybe something like the following formatted and consistency-tuned version: > > typedef enum { > TAG_FLAG_NONE = 0, > > /* Operations are synced to maildir, if possible. > */ > TAG_FLAG_MAILDIR_SYNC = (1 << 0), > > /* Remove all tags from message before applying list. > */ > TAG_FLAG_REMOVE_ALL = (1 << 1), > > /* Don't try to avoid database operations. Useful when we > * know that message passed needs these operations. > */ > TAG_FLAG_PRE_OPTIMIZED = (1 << 2), > > /* Accept strange tags that might be user error; > * intended for use by notmuch-restore. > */ > TAG_FLAG_BE_GENEROUS = (1 << 3) > > } tag_op_flag_t; > Applied. We may have to fight uncrustify on this, but we both know who likes to play with uncrustify config ;). d