Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 8F77D431FD0 for ; Fri, 28 Jan 2011 00:51:35 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.09 X-Spam-Level: X-Spam-Status: No, score=-0.09 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0ZztL5KXR1M6 for ; Fri, 28 Jan 2011 00:51:35 -0800 (PST) Received: from homiemail-a23.g.dreamhost.com (caiajhbdcbef.dreamhost.com [208.97.132.145]) by olra.theworths.org (Postfix) with ESMTP id EB02E431FB5 for ; Fri, 28 Jan 2011 00:51:34 -0800 (PST) Received: from homiemail-a23.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a23.g.dreamhost.com (Postfix) with ESMTP id 2C8D04B006D; Fri, 28 Jan 2011 00:51:33 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=SSpaeth.de; h=from:to:cc:subject :in-reply-to:references:date:message-id:mime-version: content-type; q=dns; s=sspaeth.de; b=D536UMQojiicyrwTybxs2xNSPI4 0P0ogTtou7q+CrH6pAILrzKeKiiOGlLZnNEp2UfsivJoIsUhZX7RFqmDEmD/oG3L UnlF9g99IdwyYWTBUjR4UlSOJIyQldqo9y78Q5IykkAbJu7pZw2uhSGTfJUa5LDa o47haHbOUzyqVps0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=SSpaeth.de; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version: content-type; s=sspaeth.de; bh=bkD+Hm+HQIpDoTevLBT0H+W/fO0=; b=f PfULKEWdmtQDTchsio1pZq5Ss1kNBCmyyc8KUzepCl90DgWEehpkKNUqQJWLXTjz duT8EpDn3yxNJve1qxNB4pR2bPM+8x8zKtxIwF+JO2IPGYr7tTjpn7gBMKA5FCCB MyBkwo6gfhA6P+ZoifloMUugH3gjaHpyIQSxNoGMb4= Received: from spaetzbook.sspaeth.de (mtec-hg-docking-1-dhcp-186.ethz.ch [129.132.133.186]) (Authenticated sender: fax@sspaeth.de) by homiemail-a23.g.dreamhost.com (Postfix) with ESMTPA id 7780A4B0060; Fri, 28 Jan 2011 00:51:31 -0800 (PST) Received: by spaetzbook.sspaeth.de (sSMTP sendmail emulation); Fri, 28 Jan 2011 09:51:29 +0100 From: Sebastian Spaeth To: Austin Clements , Carl Worth Subject: Re: [PATCH 1/3] new: Do not defer maildir flag synchronization during the first run In-Reply-To: References: User-Agent: Notmuch/0.5-37-g3863e88 (http://notmuchmail.org) Emacs/23.1.1 (x86_64-pc-linux-gnu) Date: Fri, 28 Jan 2011 09:51:29 +0100 Message-ID: <87zkql76ni.fsf@SSpaeth.de> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jan 2011 08:51:35 -0000 --=-=-= On Thu, 27 Jan 2011 19:08:38 -0500, Austin Clements wrote: > I added a "notmuch_database_remove_message_get" to the public API that's > just like "notmuch_database_remove_message" except that it also returns a > notmuch_message_t if other instances of the message still exist. It feels > clunky to have two almost identical variants of this function. Is this the > preferred way to change the public API? Or should I just add the argument > to the existing function and fix the other three calls to it? Just adding an argument to the public API without library version bump would break my python bindings. So if we modify the public API, I would prefer if we rename the function and remove the old one completely. That I could detect at least. Sebastian --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAk1Cg5EACgkQVYX1jMgnoGLU1QCeK9NO2LKxXgpGewkBIf5FRrYb qWcAnAq3NAbMjONycWu1iz7l4PdfPeRJ =//gL -----END PGP SIGNATURE----- --=-=-=--