From: Aaron Ecay <aaronecay@gmail.com>
To: Adam Wolfe Gordon <awg+notmuch@xvx.ca>, notmuch@notmuchmail.org
Subject: Re: [PATCH 4/4] emacs: Use the new JSON reply format.
In-Reply-To: <1326009162-19524-5-git-send-email-awg+notmuch@xvx.ca>
References: <1326009162-19524-1-git-send-email-awg+notmuch@xvx.ca>
	<1326009162-19524-5-git-send-email-awg+notmuch@xvx.ca>
User-Agent: Notmuch/0.10.1+56~gd709fd6 (http://notmuchmail.org)
	Emacs/24.0.92.3 (i386-apple-darwin10.8.0)
Date: Sun, 08 Jan 2012 20:27:36 -0500
Message-ID: <m2ty45is1j.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list

Adam,

One comment below.

On Sun,  8 Jan 2012 00:52:42 -0700, Adam Wolfe Gordon <awg+notmuch@xvx.ca> =
wrote:
> From: Adam Wolfe Gordon <awg@xvx.ca>
>=20
> Using the new JSON reply format allows emacs to quote HTML parts
> nicely by first parsing them with w3m, then quoting them. This is
> very useful for users who regularly receive HTML-only email.
>=20
> The behavior for messages that contain plain text parts should be
> unchanged, except that an additional quoted line is added to the end
> of the reply message.  The test has been updated to reflect this.
> ---
>  emacs/notmuch-mua.el |   62 +++++++++++++++++++++++++++++++++++++++-----=
-----
>  test/emacs           |    1 +
>  2 files changed, 50 insertions(+), 13 deletions(-)
>=20
> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
> index 7114e48..7f894cb 100644
> --- a/emacs/notmuch-mua.el
> +++ b/emacs/notmuch-mua.el
> @@ -19,6 +19,7 @@
>  ;;
>  ;; Authors: David Edmondson <dme@dme.org>
>=20=20
> +(require 'json)
>  (require 'message)
>=20=20
>  (require 'notmuch-lib)
> @@ -71,27 +72,62 @@ list."
>  	    (push header message-hidden-headers)))
>  	notmuch-mua-hidden-headers))
>=20=20
> +(defun w3m-region (start end)) ;; From `w3m.el'.

What is the purpose of the above line?  If it is to make the compiler
aware of the function, you should use =E2=80=98declare-function=E2=80=99 in=
stead.  Defun
will erase the original definition of the w3m-region function.

--=20
Aaron Ecay