From: Michal Sojka <sojkam1@fel.cvut.cz>
To: David Bremner <david@tethera.net>, Jani Nikula <jani@nikula.org>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH] cli: add --output=address-{from, to,
	all} to notmuch search
In-Reply-To: <87k34zbcy3.fsf@maritornes.cs.unb.ca>
References: <871troub1v.fsf@qmul.ac.uk>
	<1410021689-15901-1-git-send-email-jani@nikula.org>
	<87k34zbcy3.fsf@maritornes.cs.unb.ca>
User-Agent: Notmuch/0.18.1+94~gceee2d7 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Sat, 20 Sep 2014 10:04:08 +0200
Message-ID: <87tx427m6f.fsf@steelpick.2x.cz>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Fri, Sep 19 2014, David Bremner wrote:
> Jani Nikula <jani@nikula.org> writes:
>
>> +	    if (name && *name)
>> +		full_address = talloc_asprintf (NULL, "%s <%s>", name, addr);
>> +	    else
>> +		full_address = talloc_asprintf (NULL, "<%s>", addr
>
> Is there some reason not to use sprinter as a talloc context here?
>
>> +
>> +	    if (!full_address)
>> +		break;
>
> Is the error here out of memory? Maybe an error message would be a good
> idea.
>
>
> Obviously the docs need to be updated as well, and ideally the tests.  I
> think Jani was hinting that he didn't want to be the person to do
> that. Any volunteers?

Yes, I'll look at that. It will probably take me a few days.

-Michal