Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 4181F431FD0 for ; Tue, 7 Dec 2010 15:33:20 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.99 X-Spam-Level: X-Spam-Status: No, score=-0.99 tagged_above=-999 required=5 tests=[ALL_TRUSTED=-1, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8b-c0L0pWqaJ; Tue, 7 Dec 2010 15:33:18 -0800 (PST) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id A87B0431FB5; Tue, 7 Dec 2010 15:33:18 -0800 (PST) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id 4FA932540E7; Tue, 7 Dec 2010 15:33:18 -0800 (PST) From: Carl Worth To: Michal Sojka , notmuch@notmuchmail.org Subject: Re: [PATCH 3/5] test: Break on test script (or other) error In-Reply-To: <1289771672-9204-3-git-send-email-sojkam1@fel.cvut.cz> References: <87hbfjr2sr.fsf@steelpick.2x.cz> <1289771672-9204-3-git-send-email-sojkam1@fel.cvut.cz> User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) Date: Tue, 07 Dec 2010 15:33:18 -0800 Message-ID: <878w015fb5.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Dec 2010 23:33:20 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Sun, 14 Nov 2010 22:54:30 +0100, Michal Sojka wrot= e: > Break notmuch-test whenever a test script returns non-zero status. > This happens either when some test from the script fails or when there > is an error in the script. >=20 > This is especially useful in the latter case since the error may not > appear in the final aggregated results. Hi Michal, I'm reverting this patch now, with the following commit message: Revert "test: Break on test script (or other) error" =20=20=20=20 This reverts commit f22a7ec1e28d1264cf9d67d78796b8ab22e09a35. =20=20=20=20 Interrupting the test suite due to an actual bug in a test script would be just fine, but interrupting the run of the entire test suite at the first test failure is unacceptable. As I say there, if we could detect an actual bug in the test script, and only interrupt then, then that would be great, (perhaps using some value other than 1 for the test-failure indication in test_done?). As it is, though, I'm implementing a fix for a BROKEN test case in one script, and that's causing a failure in an earlier test script. And the interruption is causing me pain since the script I *really* want to run isn't even getting run. Let me know if you've got some good ideas for a better fix here. =2DCarl =2D-=20 carl.d.worth@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iD8DBQFM/sQ+6JDdNq8qSWgRAgOQAJ48GsE/6tC3/Wl2yp7oFY9/MNekBwCfeDnz 3PYS+jbcCTs6vW0NtIfDxEM= =OD1Y -----END PGP SIGNATURE----- --=-=-=--