From: Pieter Praet <pieter@praet.org>
To: David Bremner <david@tethera.net>, David Edmondson <dme@dme.org>,
	Jani Nikula <jani@nikula.org>
Subject: Re: [PATCH] emacs: globally replace non-branching "(if COND (progn
	..." with "(when ..."
In-Reply-To: <87y5ssxam7.fsf@zancas.localnet>
References: <87k44uprvy.fsf@praet.org>
	<1326532638-22068-1-git-send-email-pieter@praet.org>
	<87y5ssxam7.fsf@zancas.localnet>
User-Agent: Notmuch/0.11+132~ga81001f (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-unknown-linux-gnu)
Date: Mon, 30 Jan 2012 08:03:59 +0100
Message-ID: <8739ax7jts.fsf@praet.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Precedence: list

On Sat, 28 Jan 2012 08:41:36 -0400, David Bremner <david@tethera.net> wrote:
> On Sat, 14 Jan 2012 10:17:18 +0100, Pieter Praet <pieter@praet.org> wrote:
> > Less code, same results, without sacrificing readability.
> > 
> 
> This looks OK, although the re-indenting makes these kind of changes
> painful to review (not that I'm suggesting we should re-indent, just
> some random complaining).
> 

You can use `diff-refine-hunk' to see what the actual changes are.

Try this:

  #+begin_src emacs-lisp
    (global-set-key (kbd "C-c /")
                    (lambda()
                      "Refine display of unified diff hunks"
                      (interactive)
                      (save-excursion
                        (goto-char (point-min))
                        (while (re-search-forward
                                diff-hunk-header-re-unified
                                nil t)
                          (diff-refine-hunk)))))
  #+end_src

Work pretty much *anywhere*.

Note: it does NOT work in `notmuch-show-mode' (not even with
`notmuch-wash-convert-inline-patch-to-part' disabled), but this is
easily solved by first running `notmuch-show-view-raw-message' ("V")
and `diff-mode' (to fontify the buffer)...

> d
> 
> 


Peace

-- 
Pieter