Return-Path: <david@tethera.net>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id E910F6DE01F7
 for <notmuch@notmuchmail.org>; Fri, 18 Sep 2015 05:04:40 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 0.114
X-Spam-Level: 
X-Spam-Status: No, score=0.114 tagged_above=-999 required=5 tests=[AWL=0.114]
 autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id OV6ppnVJwvaF for <notmuch@notmuchmail.org>;
 Fri, 18 Sep 2015 05:04:39 -0700 (PDT)
Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224])
 by arlo.cworth.org (Postfix) with ESMTPS id E95E96DE00DE
 for <notmuch@notmuchmail.org>; Fri, 18 Sep 2015 05:04:38 -0700 (PDT)
Received: from remotemail by gitolite.debian.net with local (Exim 4.80)
 (envelope-from <david@tethera.net>)
 id 1ZcuOC-0001FU-V0; Fri, 18 Sep 2015 12:03:40 +0000
Received: (nullmailer pid 9821 invoked by uid 1000); Fri, 18 Sep 2015
 12:03:20 -0000
From: David Bremner <david@tethera.net>
To: Johannes Schauer <josch@debian.org>, notmuch@notmuchmail.org
Subject: Re: [bug] notmuch requires Content-Disposition mime header value to
 be lower case
In-Reply-To: <20150917083956.1941.35098@localhost>
References: <20150917070056.1941.94846@localhost>
 <20150917083612.1941.22480@localhost> <20150917083956.1941.35098@localhost>
User-Agent: Notmuch/0.20.2+73~gd432116 (http://notmuchmail.org) Emacs/24.5.1
 (x86_64-pc-linux-gnu)
Date: Fri, 18 Sep 2015 09:03:20 -0300
Message-ID: <87pp1grl2v.fsf@maritornes.cs.unb.ca>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Sep 2015 12:04:41 -0000

Johannes Schauer <josch@debian.org> writes:


> Funnily though there seem to be some weird newline differences that I cannot
> explain, so I left them for somebody else to fix.
>

Looking at the files (.EXPECTED and .OUTPUT) in test/tmp.T190-multipart,
there's more than whitespace changes. Some things that used to marked
"attachment" in the output are now marked "part".

> diff --git a/test/T190-multipart.sh b/test/T190-multipart.sh
> index 7c4c9f7..f16cc90 100755
> --- a/test/T190-multipart.sh
> +++ b/test/T190-multipart.sh
> @@ -48,7 +48,7 @@ cat embedded_message >> ${MAIL_DIR}/multipart
>  cat <<EOF >> ${MAIL_DIR}/multipart
>  
>  --=-=-=
> -Content-Disposition: attachment; filename=attachment
> +Content-Disposition: ATTACHMENT; FILENAME=attachment
>  
>  This is a text attachment.
>  
> @@ -487,7 +487,7 @@ This is an embedded message, with a multipart/alternative part.
>  --==-=-==--
>  
>  --=-=-=
> -Content-Disposition: attachment; filename=attachment
> +Content-Disposition: ATTACHMENT; FILENAME=attachment
>  
>  This is a text attachment.
>  

I'd recommend making your own new test, rather than modifying existing
ones to test multiple things.  I'd also recommend using json / sexp
output for your tests, since the ad-hoc text format is kindof
semi-deprecated.

d