Date: Mon, 18 Oct 2010 10:12:31 -0400
From: Mike Kelly <pioto@pioto.org>
To: notmuch@notmuchmail.org
Subject: Re: [PATCH 0/4] Maildir synchronization v2
Message-ID: <20101018101231.69904381@pioto.org>
In-Reply-To: <1286972038-21064-1-git-send-email-sojkam1@fel.cvut.cz>
References: <1286972038-21064-1-git-send-email-sojkam1@fel.cvut.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: list

On Wed, 13 Oct 2010 14:13:54 +0200
Michal Sojka <sojkam1@fel.cvut.cz> wrote:

> Hi,
> 
> this is an updated version of patches sent in
> id:1273580061-22580-1-git-send-email-sojkam1@fel.cvut.cz. Only the
> last patch (tests) was actually updated to work with new test suite.
> These patches has already been tested by several people and I think
> they are ready to be merged. They can be pulled by:
> 
> git pull git://rtime.felk.cvut.cz/notmuch maildir-sync-v2

I've tested these patches on Linux, and they seem to work as expected.
However, I'd like to suggest/request that the level-4 syncing of a
filename should happen in notmuch_(message|thread)_(add|remove)_tag(),
not in notmuch-tag.cc. Otherwise, anyone using libnotmuch directly
(e.g. alternative clients, things using python bindings, etc) will not
benefit from this.

-- 
Mike Kelly