Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 74C1D429E21 for ; Tue, 10 Jan 2012 03:17:26 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V8fox4GC5fJG for ; Tue, 10 Jan 2012 03:17:24 -0800 (PST) Received: from mail-we0-f181.google.com (mail-we0-f181.google.com [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 5EE8A431FD0 for ; Tue, 10 Jan 2012 03:17:24 -0800 (PST) Received: by werm12 with SMTP id m12so4079690wer.26 for ; Tue, 10 Jan 2012 03:17:23 -0800 (PST) Received: by 10.216.133.74 with SMTP id p52mr603091wei.39.1326194243193; Tue, 10 Jan 2012 03:17:23 -0800 (PST) Received: from hotblack-desiato.hh.sledj.net (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) by mx.google.com with ESMTPS id r1sm1061758wia.8.2012.01.10.03.17.21 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 10 Jan 2012 03:17:22 -0800 (PST) Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) id ECD129FE69; Tue, 10 Jan 2012 11:17:19 +0000 (GMT) To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH 2/3 v2] test: Add tests for `notmuch-show-clean-address'. In-Reply-To: <87wr8zke99.fsf@zancas.localnet> References: <1324980940-25466-1-git-send-email-dme@dme.org> <1325237978-22893-1-git-send-email-dme@dme.org> <1325237978-22893-2-git-send-email-dme@dme.org> <87wr8zke99.fsf@zancas.localnet> User-Agent: Notmuch/0.10.2+186~gd0f7804 (http://notmuchmail.org) Emacs/24.0.92.1 (x86_64-pc-linux-gnu) From: David Edmondson Date: Tue, 10 Jan 2012 11:17:16 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jan 2012 11:17:26 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 10 Jan 2012 07:06:58 -0400, David Bremner wrote: > On Fri, 30 Dec 2011 09:39:37 +0000, David Edmondson wrote: > > --- > >=20 > > Added backslash test. UTF8 round-trip still isn't right. > >=20 >=20 > Do you mind explaining a bit better in the commit message what the issue > is here? I'm not completely sure. The expected output file is supposed to contain some UTF8 encoded text. One of the addresses to be tested has a 'human readable' part that has the same UTF8 text. Testing the functions directly within emacs retains the text correctly encoded. Pushing the text through the test suite results in text that does not correctly match the expected output. There are many places where things could be wrong: - the expected output file doesn't include the correct UTF8 text (but it looks fine in emacs), - the test wrapper script doesn't correctly pass around the UTF8 encoded text, - the emacs reader is not correctly loading the UTF8 encoded text, - . --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk8MHjwACgkQaezQq/BJZRbZUQCfVkIthpPMEt7CEC2VuPuqjKRp XtoAn1YFGCpjtyIqGU96ELQrhInUWwRW =8ntf -----END PGP SIGNATURE----- --=-=-=--