From: Pieter Praet <pieter@praet.org>
To: Kan-Ru Chen <kanru@kanru.info>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] emacs: notmuch-hello: Avoid going to end-of-line in
	search box
In-Reply-To: <1280195325-9066-2-git-send-email-kanru@kanru.info>
References: <1280195325-9066-1-git-send-email-kanru@kanru.info>
	<1280195325-9066-2-git-send-email-kanru@kanru.info>
User-Agent: Notmuch/0.5-86-g4875299 (http://notmuchmail.org) Emacs/23.1.50.1
	(x86_64-pc-linux-gnu)
Date: Sat, 16 Apr 2011 15:07:00 +0200
Message-ID:
 <87zknquyyz.fsf@A7GMS.i-did-not-set--mail-host-address--so-tickle-me>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Tue, 27 Jul 2010 09:48:44 +0800, Kan-Ru Chen <kanru@kanru.info> wrote:
> widget-end-of-line checks eolp to decide whether C-e in a fixed size
> field should go to the end of the text in the field or the end of
> the field itself. So put a trailing white space to pad the search
> field.
> 
> Previous behavior:
> 
>  Search: [text                _]
> 
> Now:
> 
>  Search: [text_                ]
> ---
>  emacs/notmuch-hello.el |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
> index f8ae332..6ef03bb 100644
> --- a/emacs/notmuch-hello.el
> +++ b/emacs/notmuch-hello.el
> @@ -416,10 +416,10 @@ Complete list of currently available key bindings:
>  		       ;; Leave some space at the start and end of the
>  		       ;; search boxes.
>  		       :size (max 8 (- (window-width) notmuch-hello-indent
> -				       (length "Search: ")))
> +				       (length "Search: ") 1 ))
>  		       :action (lambda (widget &rest ignore)
>  				 (notmuch-hello-search (widget-value widget))))
> -	(widget-insert "\n")
> +	(widget-insert " \n")
>  
>  	(when notmuch-hello-recent-searches
>  	  (widget-insert "\nRecent searches: ")
> -- 
> 1.7.1
> 
> 


+1

Can't imagine how this has been collecting dust for so long.

Very useful, very concise, and still applies cleanly to HEAD.

Peace

-Pieter