From: Austin Clements <aclements@csail.mit.edu>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: show: make RET always toggle parts where plausible
In-Reply-To: <1354700480-5170-1-git-send-email-markwalters1009@gmail.com>
References: <1354663662-20524-4-git-send-email-markwalters1009@gmail.com>
	<1354700480-5170-1-git-send-email-markwalters1009@gmail.com>
User-Agent: Notmuch/0.14+159~g6895fee (http://notmuchmail.org) Emacs/23.4.1
	(i486-pc-linux-gnu)
Date: Mon, 10 Dec 2012 23:07:52 -0500
Message-ID: <87obi1nsdj.fsf@awakening.csail.mit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

I would just fold this patch in with the rest of the series.  This is
definitely the right way to toggle.

On Wed, 05 Dec 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> This makes RET toggle the visibility of any part which has a component
> that can be displayed in the buffer. This included text parts (plain/
> html/ x-tex etc) and images. Parts which cannot be displayed (eg pdf)
> RET acts as before and saves/views etc.
>
> Definite actions can always be accessed with s,v and o (eg v to view a
> text/html part in a browser).
>
> ---
>
> This is a slight tweak at Jani's suggestion on irc. Applies on top of
> the previous series.
>
>
>
>  emacs/notmuch-show.el |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index a4daff8..e319e5c 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -2028,7 +2028,7 @@ the user (see `notmuch-show-stash-mlarchive-link-alist')."
>  (defun notmuch-show-part-button-default (&optional button)
>    (interactive)
>    (let ((button (or button (button-at (point)))))
> -    (if (invisible-p (button-get button 'invisibility-spec))
> +    (if (button-get button 'invisibility-spec)
>  	(notmuch-show-toggle-invisible-part-action button)
>        (notmuch-show-part-button-internal button notmuch-show-part-button-default-action))))
>  
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch