Date: Mon, 23 Nov 2009 01:53:39 +0100
From: Adrian Perez de Castro <aperez@igalia.com>
To: notmuch@notmuchmail.org
Message-ID: <20091123015339.79e51228@hikari>
In-Reply-To: <87r5rqks0m.fsf@yoom.home.cworth.org>
References: <1258762638-22905-1-git-send-email-aperez@igalia.com>
	<87r5rqks0m.fsf@yoom.home.cworth.org>
Organization: Igalia
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAAXNSR0IArs4c6QAAADBQTFRFBwcHFhYWKCgoNzc3SEhIV1dXaGhod3d3iIiIlpaWqKiouLi4x8fH2NjY5+fn/v7+rSjDkgAAAjVJREFUOE9l07tvE0EQwOHfrkV9O+eko7g701BBfECJsIigT2IpooIqaSiRUEB0REj00FBQgYSCkhry+gecUPJybJeIxLumTbilsH2PMNXufDOa3ZVW+1JkpbUmD/8+vXR3c7or4Gz93mH309Kz8/C9/RQge7VfhW/LW+PF8IkrQ7Z6OKmQr1tl+LU/yWP9mxJka9O88fZHPwf/7u0kLyCnX3I4fQhgjAgIfi+HHw5A1Y2ggIMcFKAEnRoL0M3BosI4TI2IATjuT8DvSNJoNNJgkIhxlr9TUHeSpDnfohlIrMBlU+BGmsZqfr69FMfGMw4NoG835+J62riWyjQ/uXlTQjNUIoYegMsBM0pCD8oDas7n4HQsBghXFxJTW42KDs+4XLfjsN0wOYgABqARjMKIHIaAQnmHjsI5Cvi9Cf6k03OoWBkpIP3Q7354+dEimFBKHbMP9oKjwfd9gbrxR5KDToczK4uPF8UgNomKU2GaENRi77zyDKICxKBS4xXYbONPMQMdYZTBwMiMWiUg9g6UJ3OBogzjV8E7sBVwyvfAOYdQhsABzuOxI1MGZbs98Q6Md5UOfbbR2R0eWOesrnRw5ajT6f60LrNhWIHZpBnUWv2s14ukArWWTqTes3YQxRXgFkcMu70TPYqqUBs0YwmO967OVIdTG4bY4a7WLaqgLm5vbHdH5np0Dri//fmg7y8scB4u3+zsuNlH0X+g19bby69b+TYH6isvns8VdQWgxj9tHP8AR5/hSdYqkwsAAAAASUVORK5CYII=
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=PGP-SHA1;
	boundary="Sig_/ryVqa/f7wDpCJ1s=bq1wDLq";
	protocol="application/pgp-signature"
Subject: Re: [notmuch] [PATCH] Support for printing file paths in new command
Precedence: list

--Sig_/ryVqa/f7wDpCJ1s=bq1wDLq
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Mon, 23 Nov 2009 01:24:09 +0100, Carl wrote:

> On Sat, 21 Nov 2009 01:17:18 +0100, Adrian Perez <aperez@igalia.com> wrot=
e:
> > For very large mail boxes, it is desirable to know which files are being
> > processed e.g. when a crash occurs to know which one was the cause. Als=
o,
> > it may be interesting to have a better idea of how the operation is
> > progressing when processing mailboxes with big messages.
> >=20
> > This patch adds support for printing messages as they are processed by
> > "notmuch new":
>=20
> Hey, that's pretty nice.

Thanks!

As a small improvement, I will send another patch in a while, which will
avoid sending ANSI escapes when output is not a terminal, and print one
file path per line in that case.

> I've pushed this now, (and I'm almost tempted to make it the
> default...).

IMHO it would be nice to have the messages-per-second information as
well in verbose mode before making it the default. I think I could cook
up a patch for that, but printing messages-per-second would mean calling
gettimeofday() for each processed file. Do you think that will be
acceptable from a performance POV? (Of course using silent mode would
still only call it once per second).

Regards,

--=20
Adrian Perez de Castro <aperez@igalia.com>
Igalia - Free Software Engineering

--Sig_/ryVqa/f7wDpCJ1s=bq1wDLq
Content-Type: application/pgp-signature; name=signature.asc
Content-Disposition: attachment; filename=signature.asc

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.13 (GNU/Linux)

iEYEARECAAYFAksJ3RgACgkQkcVZ2+TJEjuZhgCeLlmfTJSksh9WqD00P5aa9Moj
NLEAnjiFXQM9qdHfBTT70TrdOQjH1ZyN
=lt+V
-----END PGP SIGNATURE-----

--Sig_/ryVqa/f7wDpCJ1s=bq1wDLq--