From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: Don't signal an error when reaching the end of the
	search results.
In-Reply-To: <cunsjk3rcif.fsf@hotblack-desiato.hh.sledj.net>
References: <1324370714-28545-1-git-send-email-dme@dme.org>
	<yf662h0mo6y.fsf@taco2.nixu.fi>
	<cunsjk3rcif.fsf@hotblack-desiato.hh.sledj.net>
User-Agent: Notmuch/0.10.2+137~gbed6022 (http://notmuchmail.org) Emacs/23.3.1
	(i686-pc-linux-gnu)
Date: Thu, 29 Dec 2011 11:04:43 +0200
Message-ID: <yf6oburn3ys.fsf@taco2.nixu.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Thu, 29 Dec 2011 08:46:32 +0000, David Edmondson <dme@dme.org> wrote:
> On Wed, 28 Dec 2011 22:33:09 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> > On Tue, 20 Dec 2011 08:45:14 +0000, David Edmondson <dme@dme.org> wrote:
> > > With the default configuration ('space' moves through the messages
> > > matching the search and back to the results index at the end) it's
> > > unnecessary to signal an error when the last message has been read, as
> > > this is the common case.
> > > 
> > > Moreover, it's very annoying when `debug-on-error' is t.
> > > ---
> > 
> > I'd say '+1' but I could not reproduce the case.
> 
> That's puzzling. Without the patch, if you hit 'space' on the last
> message in a `notmuch-show' buffer that is the last thread in a
> `notmuch-search' buffer, you should see the error when you are returned
> to the `notmuch-search' buffer. Does that not happen?

Now that you said it I knew what to test (and I had temporarily
restored " " binding to it's original in notmuch show mode).

+1 for the patch.

Tomi