Return-Path: <cworth@cworth.org>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id D8C5E4196F3
	for <notmuch@notmuchmail.org>; Sat, 24 Apr 2010 06:52:38 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -2.89
X-Spam-Level: 
X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5
	tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01]
	autolearn=ham
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id ccvqygkBE62J; Sat, 24 Apr 2010 06:52:38 -0700 (PDT)
Received: from yoom.home.cworth.org (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id EC15D431FC1;
	Sat, 24 Apr 2010 06:52:37 -0700 (PDT)
Received: by yoom.home.cworth.org (Postfix, from userid 1000)
	id AC253568DEC; Sat, 24 Apr 2010 06:52:37 -0700 (PDT)
From: Carl Worth <cworth@cworth.org>
To: Sebastian Spaeth <Sebastian@SSpaeth.de>,
	Notmuch development list <notmuch@notmuchmail.org>
Subject: Re: notmuch segfault
In-Reply-To: <87d3xqti3o.fsf@SSpaeth.de>
References: <8739ym4mxk.fsf@SSpaeth.de> <87d3xqti3o.fsf@SSpaeth.de>
User-Agent: Notmuch/0.2-174-g6ddc2e0 (http://notmuchmail.org) Emacs/23.1.1
	(i486-pc-linux-gnu)
Date: Sat, 24 Apr 2010 06:52:37 -0700
Message-ID: <87eii5neje.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Apr 2010 13:52:39 -0000

--=-=-=

On Fri, 23 Apr 2010 15:26:51 +0200, "Sebastian Spaeth" <Sebastian@SSpaeth.de> wrote:
> It happened again. Both times I had pressed "G" which calls offlineimap
> and which removed messages that the notmuch database still thought are there.

Thanks for the report, Sebastian.

I've just audited all calls to notmuch_message_get_header and tried to
handle NULL in all cases.

Of course, I haven't tested this thoroughly, but we'll hope that things
are better at least.

And perhaps someday someone will hook up some exhaustive
fault-injection-based testing to catch things like this.

-Carl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFL0vel6JDdNq8qSWgRAuJCAJ40QsUb9YRmxpniErs8uBtUzIMtZwCeIhz3
EE6kPknHOH2kSJbs9ccc8fA=
=AvUw
-----END PGP SIGNATURE-----
--=-=-=--