Return-Path: <markwalters1009@gmail.com>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 2464F431FBD
	for <notmuch@notmuchmail.org>; Mon, 12 May 2014 15:08:33 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0.201
X-Spam-Level: 
X-Spam-Status: No, score=0.201 tagged_above=-999 required=5
	tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
	FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001,
	RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id GXMWcHb1G6TB for <notmuch@notmuchmail.org>;
	Mon, 12 May 2014 15:08:25 -0700 (PDT)
Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com
 [74.125.82.48])	(using TLSv1 with cipher RC4-SHA (128/128 bits))	(No client
 certificate requested)	by olra.theworths.org (Postfix) with ESMTPS id
 7CA24431FAF	for <notmuch@notmuchmail.org>; Mon, 12 May 2014 15:08:25 -0700
 (PDT)
Received: by mail-wg0-f48.google.com with SMTP id b13so7568635wgh.19
	for <notmuch@notmuchmail.org>; Mon, 12 May 2014 15:08:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=from:to:subject:in-reply-to:references:user-agent:date:message-id
	:mime-version:content-type;
	bh=bZYrAigDZfQsRqze+DxsCnf9aD7d/qIiCtJWz785+ZA=;
	b=Kp2TO7gtEs+3BXDv2cx9hIiHUo/ZPUyT+hExw/qbskjIuSvgLqxLL4zyWhzv9d8K8n
	fB9conbyMZCXUM6RJHKQ2aR0H/xcPsVi60YeIbOGI+f2atWVbDLKXhKiBQJGAd2EaEUN
	uRDX1UCBM4GZlde9qyGPqhpynyq36KSWbZgYEJfjDWTzS388X4vY20aS6ruA2jeO5jXr
	u6vLCDZdfLe6KQ5DuqOS25MAHnNNDMKVGGeiTnBjrlFa68QhH9s+51irTkoi8HSMbnTn
	aQE09EN5Gx3f/UmJo5mW6d3ounlgbEJJPjdFKRTgPHqbW20S0GPVPfxVjW8jHW/Zw9AG
	n60g==
X-Received: by 10.194.92.177 with SMTP id cn17mr23616128wjb.18.1399932504076; 
	Mon, 12 May 2014 15:08:24 -0700 (PDT)
Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162])
	by mx.google.com with ESMTPSA id
	mw4sm18349818wib.12.2014.05.12.15.08.22 for <multiple recipients>
	(version=TLSv1.2 cipher=RC4-SHA bits=128/128);
	Mon, 12 May 2014 15:08:23 -0700 (PDT)
From: Mark Walters <markwalters1009@gmail.com>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v3 0/9] emacs: Improve the cited message included in
	replies
In-Reply-To: <1399897769-26809-1-git-send-email-dme@dme.org>
References: <87sixdujkv.fsf@qmul.ac.uk>
	<1399897769-26809-1-git-send-email-dme@dme.org>
User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1
	(x86_64-pc-linux-gnu)
Date: Mon, 12 May 2014 23:08:20 +0100
Message-ID: <87vbtak5uz.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Mon, 12 May 2014 22:08:33 -0000


On Mon, 12 May 2014, David Edmondson <dme@dme.org> wrote:
> emacs: Improve the cited message included in replies
>
> I tried to do things in small increments to make it easier to review.
>
> v2:
> - Don't run the text/plain hooks when generating the message to quote.
>
> v3:
> - Remove the 'no-button code, as it's no longer used.
> - Control the insertion of part headers using a function.
> - Fix the tests.

I think I broadly like this series. I haven't thought through all the
ramifications yet so this is just some first thoughts. I will also send
some comments on individual patches.

In notmuch-show we go to notmuch-show-insert-part-*/* to
notmuch-mm-display-part-inline and then leave the decision to inline to
mm-inlined-types. I think this means that, by default, we will not
inline signatures amongst other things.

So at the least I think we should decide whether we want to override
mm-inlined-types. Alternatively, and in my view preferably, we could
have a function or variable of our own which says which parts to
include. Indeed, if do it with a function we might be able to make an
option to reply to mean "include parts currently shown in the
notmuch-show buffer" which might be nice.

There is a related question and possible bug that we might be able to
do something about at the same time: should we include text parts in the
reply if they have content-disposition attachment? I have been caught
about by this on one occasion replying to a message with a 500K log file
attached (and notmuch-show/wash becomes very slow with a 500K message!)

Finally, I am not sure whether I like having buttons in the reply. My
instinct is against, but they do add context.

Best wishes

Mark




>
>
> David Edmondson (9):
>   emacs/show: Re-arrange determination if a part header is necessary
>   emacs/show: Allow the user to decide when part headers should be
>     inserted
>   emacs/show: Accommodate the lack of part header buttons
>   emacs/mua: Generate improved cited text for replies
>   emacs/show: Remove the 'no-buttons option of
>     `notmuch-show-insert-bodypart'
>   emacs/mua: Don't insert part headers in citations
>   test: Update the test output to accord with the reply changes
>   emacs/mua: Insert part headers depending on the message
>   test: Update the test output to accord with more reply changes
>
>  emacs/notmuch-mua.el  |  82 +++++++++++++++++++-----------
>  emacs/notmuch-show.el | 135 +++++++++++++++++++++++++++++++-------------------
>  test/T310-emacs.sh    |  44 ++++++++++++++++
>  3 files changed, 180 insertions(+), 81 deletions(-)
>
> -- 
> 2.0.0.rc0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch