Return-Path: <tomi.ollila@nixu.com>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id E551C429E25
	for <notmuch@notmuchmail.org>; Thu, 12 Jan 2012 04:59:19 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id ZiCWUav3UNNK for <notmuch@notmuchmail.org>;
	Thu, 12 Jan 2012 04:59:19 -0800 (PST)
Received: from mail-gw3.nixu.fi (mail-gw3.nixu.fi [193.209.237.7])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id CC503431FB6
	for <notmuch@notmuchmail.org>; Thu, 12 Jan 2012 04:59:18 -0800 (PST)
Received: from pps.filterd (mail-gw3 [127.0.0.1])
	by mail-gw3.nixu.fi (8.14.4/8.14.4) with SMTP id q0CCxDDj031716;
	Thu, 12 Jan 2012 14:59:13 +0200
Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])
	by mail-gw3.nixu.fi with ESMTP id 114cs105ws-1
	(version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
	Thu, 12 Jan 2012 14:59:12 +0200
Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])
	by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id
	q0CCxBjO013776; Thu, 12 Jan 2012 14:59:11 +0200
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Austin Clements <amdragon@MIT.EDU>, Jani Nikula <jani@nikula.org>
Subject: Re: [PATCH v3 4/4] test: add tests for "notmuch reply"
	--reply-to=sender
In-Reply-To: <20120112035032.GV20796@mit.edu>
References: <cover.1325794371.git.jani@nikula.org>
	<cover.1326224339.git.jani@nikula.org>
	<33b8a00a073d39baeecc86b8b8f97683d2cec3c0.1326224339.git.jani@nikula.org>
	<20120112035032.GV20796@mit.edu>
User-Agent: Notmuch/0.10.2+176~g3f9d738 (http://notmuchmail.org) Emacs/23.3.1
	(i686-pc-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Thu, 12 Jan 2012 14:59:11 +0200
Message-ID: <yf6pqepf55s.fsf@taco2.nixu.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.5.7110,
 1.0.211,	0.0.0000	definitions=2012-01-12_06:2012-01-12, 2012-01-12,
	1970-01-01 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0
	ipscore=0 suspectscore=0
	phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0
	reason=mlx
	scancount=1 engine=6.0.2-1012030000 definitions=main-1201120083
Cc: notmuch@notmuchmail.org
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Jan 2012 12:59:20 -0000

On Wed, 11 Jan 2012 22:50:32 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> I'm not sure what the point of the last test is, but this patch
> covered everything I could think of, so LGTM.

Maybe checking that long subject line (possibly split/join sometimes in the
process) keeps it's original form (?)

LGTM (and my opinion is that 'r' in emacs is changed to 'reply-to-sender'
-- more consistent with other clients and less error prone to use (note
that I've voted this already so this doesn't increase vote count there)). 

Tomi